Bug 226213 - x11-wm/icewm: Add C++11 support (Fixes builds on 11 / CURRENT)
Summary: x11-wm/icewm: Add C++11 support (Fixes builds on 11 / CURRENT)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-02-26 08:30 UTC by Chris Hutchinson
Modified: 2018-03-03 15:41 UTC (History)
1 user (show)

See Also:
riggs: merge-quarterly+

Attachments
svn diff for x11-wm/icewm to permit building on 11, and CURRENT (998 bytes, patch)
2018-02-26 08:30 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2018-02-26 08:30:49 UTC 
Created attachment 191012 [details]
svn diff for x11-wm/icewm to permit building on 11, and CURRENT

x11-wm/icewm won't build on 11, or CURRENT due to lack of C++1 support.
The attached svn diff corrects that.
While there's still many warnings left to quiet, the attached patch
corrects the fatal errors, and permits it to build, and run w/o
problems on [at least] CURRENT

CHANGES
bump PORTREVISION
add patch for src/wmabout.cc

Tested on 12.0-CURRENT/1200054

That's it!
Thanks!

--Chris
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-03-03 15:37:11 UTC 
A commit references this bug:

Author: riggs
Date: Sat Mar  3 15:37:03 UTC 2018
New revision: 463487
URL: https://svnweb.freebsd.org/changeset/ports/463487

Log:
  Fix build on 11 and later with c++ compilers by default in c++11 mode

  PR:		226213
  Submitted by:	portmaster@bsdforge.com (maintainer)
  MFH:		2018Q1 (ports-secteam build fix blanket)

Changes:
  head/x11-wm/icewm/Makefile
  head/x11-wm/icewm/files/patch-src_wmabout.cc
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-03-03 15:39:15 UTC 
A commit references this bug:

Author: riggs
Date: Sat Mar  3 15:39:06 UTC 2018
New revision: 463488
URL: https://svnweb.freebsd.org/changeset/ports/463488

Log:
  MFH: r463487

  Fix build on 11 and later with c++ compilers by default in c++11 mode

  PR:		226213
  Submitted by:	portmaster@bsdforge.com (maintainer)

  Approved by:	ports-secteam (build fix blanket)

Changes:
_U  branches/2018Q1/
  branches/2018Q1/x11-wm/icewm/Makefile
  branches/2018Q1/x11-wm/icewm/files/patch-src_wmabout.cc
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2018-03-03 15:41:23 UTC 
Chris, on another note: Could you look into the GNOME OPTION?

When selected, check-sanity complains about gnomedesktop