Bug 226255 - www/chromium: Switch from x11-fonts/noto to x11-fonts/noto-lite
Summary: www/chromium: Switch from x11-fonts/noto to x11-fonts/noto-lite
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-02-27 23:12 UTC by Tobias Kortkamp
Modified: 2018-03-09 17:06 UTC (History)
9 users (show)

See Also:


Attachments
chromium-noto.diff (1.45 KB, patch)
2018-02-27 23:12 UTC, Tobias Kortkamp
no flags Details | Diff
patch (800 bytes, patch)
2018-03-07 00:01 UTC, Carlos J. Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2018-02-27 23:12:59 UTC
Created attachment 191066 [details]
chromium-noto.diff

Can we make the x11-fonts/noto run dependency optional?  Chromium seems to work
fine without it AFAICT and noto is a very large package (~ 770 MiB) that takes
up valuable package server space which I'd like to avoid if possible.

Thank you!
Comment 1 Steve Wills freebsd_committer freebsd_triage 2018-02-28 02:19:12 UTC
The noto package is 1.2 gb extracted, most of which is the CJK fonts. If you exclude the CJK fonts, it only installs 25mb of data. Perhaps we could split noto and put the CJK fonts into a different package and make that optional?
Comment 2 Jan Beich freebsd_committer freebsd_triage 2018-02-28 02:53:18 UTC
(In reply to Steve Wills from comment #1)
Like x11-fonts/noto-lite ?
Comment 3 Dmitri Goutnik freebsd_committer freebsd_triage 2018-02-28 03:44:51 UTC
noto-lite conflicts with noto which is a dependency of at least 2 other ports.

Arch's chromium package requires ttf-font which is provided (among others) by noto-fonts, ttf-dejavu and ttf-liberation packages. Maybe it would make sense for www/chromium to provide a choice of a font too, e.g. noto/dejavu and liberation as a minimally usable option (3mb).
Comment 4 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-02-28 11:56:05 UTC
(In reply to Dmitri Goutnik from comment #3)

I like this approach as long others agree :)

http://www.linuxfromscratch.org/blfs/view/cvs/x/TTF-and-OTF-fonts.html
Comment 5 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-02-28 12:01:53 UTC
(In reply to Steve Wills from comment #1)

It seems reasonable to split the port because Noto Sans CJK and Noto Serif CJK only cover Simplified Chinese, Traditional Chinese, Japanese, and Korean languages.

https://www.google.com/get/noto/help/cjk/
Comment 6 Jan Beich freebsd_committer freebsd_triage 2018-02-28 13:17:25 UTC
(In reply to Dmitri Goutnik from comment #3)
> Arch's chromium package requires ttf-font which is provided
> (among others) by noto-fonts, ttf-dejavu and ttf-liberation packages.

On FreeBSD x11-fonts/xorg-fonts-truetype has a similar role given package alternative aren't supported yet. www/chromium already depends on it via x11-toolkits/pango. So, x11-fonts/dejavu is always installed.
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-03-01 14:09:26 UTC
I think it's a good idea to split noto into several ports. At least CJK fonts will be a separate port.
Comment 8 OlivierW 2018-03-03 18:29:52 UTC
Hello,

I used to have x11-fonts/noto-lite installed.
Now I've just updated www/chromium and I have x11-fonts/noto instead of noto-lite.

So, like others people, I would prefer to have only noto-lite on my computer instead of the huge noto package.
Is it possible to make chromium depends on "noto OR noto-lite"?

Best Regards,
Olivier
Comment 9 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-03-06 08:20:59 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #7)

If you don't mind, go ahead :)
Comment 10 Mark Dixon 2018-03-06 08:27:01 UTC
noto conflicts with noto-lite used by Plasma5. This means at present we can have Plasma 5 or Chromium, not both. Not so great for a desktop.
Comment 11 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-03-06 08:33:02 UTC
(In reply to Mark Dixon from comment #10)

OK, then we are going to switch from x11-fonts/noto to x11-fonts/noto-lite.
Comment 12 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-03-07 00:01:31 UTC
Created attachment 191269 [details]
patch

Switch from x11-fonts/noto to x11-fonts/noto-lite
Comment 13 commit-hook freebsd_committer freebsd_triage 2018-03-07 21:07:14 UTC
A commit references this bug:

Author: cpm
Date: Wed Mar  7 21:06:40 UTC 2018
New revision: 463831
URL: https://svnweb.freebsd.org/changeset/ports/463831

Log:
  - Switch from x11-fonts/noto to x11-fonts/noto-lite
  - Bump PORTREVISION

  PR:		226255
  Reported by:	tobik

Changes:
  head/www/chromium/Makefile
Comment 14 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-08 03:03:16 UTC
(In reply to Carlos J. Puga Medina from comment #11)
Thank you!
Comment 15 Jonathan Chen 2018-03-08 18:11:43 UTC
Please make the noto/noto-lite dependancies selectable. I'm currently using noto for its extensive multilingual support, but with the latest changes it can't be used with chromium.
Comment 16 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-08 18:24:34 UTC
(In reply to Jonathan Chen from comment #15)
The conflict between noto and noto-lite could easily be resolved by
installing noto-lite into share/fonts/noto-lite instead of into
share/fonts/noto.  I see no reason why the conflict exists in the
first place.
Comment 17 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-03-08 18:51:39 UTC
(In reply to Tobias Kortkamp from comment #16)

Yes, it should fix the current conflict. 

sunpoet@ can help here.
Comment 18 commit-hook freebsd_committer freebsd_triage 2018-03-09 17:06:23 UTC
A commit references this bug:

Author: cpm
Date: Fri Mar  9 17:05:29 UTC 2018
New revision: 463978
URL: https://svnweb.freebsd.org/changeset/ports/463978

Log:
  MFH: r463831

  - Switch from x11-fonts/noto to x11-fonts/noto-lite
  - Bump PORTREVISION

  PR:		226255
  Reported by:	tobik

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2018Q1/
  branches/2018Q1/www/chromium/Makefile