Bug 226270 - databases/cockroach: Upgrade to 1.1.5
Summary: databases/cockroach: Upgrade to 1.1.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-28 22:24 UTC by James Nugent
Modified: 2018-03-04 04:27 UTC (History)
1 user (show)

See Also:

Attachments
CockroachDB 1.1.4 -> 1.1.5 Patch (880 bytes, patch)
2018-02-28 22:24 UTC, James Nugent 		no flags Details | Diff
CockroachDB v1.1.4 -> v1.1.5 (1.13 KB, patch)
2018-03-01 16:13 UTC, James Nugent 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Nugent 2018-02-28 22:24:53 UTC 
Created attachment 191090 [details]
CockroachDB 1.1.4 -> 1.1.5 Patch

Cockroach DB 1.1.5 is now available, this patch updates the port from 1.1.4.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-01 06:31:42 UTC 
Builds fail:
gmake[1]: Entering directory '/wrkdirs/usr/ports/databases/cockroach/work/cockroach-v1.1.5/src/github.com/cockroachdb/cockroach'
build/common.mk:105: *** "go1\.[89].* required (see CONTRIBUTING.md): go version go1.10 freebsd/amd64; use `make GOVERS=.*` for experiments".  Stop.
gmake[1]: Leaving directory '/wrkdirs/usr/ports/databases/cockroach/work/cockroach-v1.1.5/src/github.com/cockroachdb/cockroach'
gmake: *** [Makefile:3: buildoss] Error 2
Comment 2 James Nugent 2018-03-01 16:13:06 UTC 
Created attachment 191107 [details]
CockroachDB v1.1.4 -> v1.1.5
Comment 3 James Nugent 2018-03-01 16:13:33 UTC 
Ah, I had tested on Go 1.9, and the Makefile for the upstream has a check for supported versions. This looks like it is failing with Go 1.10 which is now in ports.

I've added a new patch which sets the option to ignore the version check. This has changed on master (likely for v2.0.0), but is correct for release 1.1.15. I believe this may also fix the build failure I saw on FreeBSD 10.3.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-03-01 20:39:22 UTC 
A commit references this bug:

Author: yuri
Date: Thu Mar  1 20:38:59 UTC 2018
New revision: 463352
URL: https://svnweb.freebsd.org/changeset/ports/463352

Log:
  databases/cockroach: Update to 1.1.5

  Port changes:
  * Changed to DISTVERSION
  * Adjusted do-build

  PR:		226270
  Submitted by:	James Nugent <freebsd@jen20.com>
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/databases/cockroach/Makefile
  head/databases/cockroach/distinfo