Bug 226293 - audio/openal-soft: upgrade/fix
Summary: audio/openal-soft: upgrade/fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Tobias Kortkamp
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2018-03-02 10:37 UTC by strangeqargo
Modified: 2018-09-11 11:00 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description strangeqargo 2018-03-02 10:37:30 UTC
current version of openal-soft in ports segfaults on 12 CURRENT making many ports unusable (telegram-desktop, assaultcube etc)


TrueOS integrated newer version, which works fine, runs desktop apps, uses official github repo and adds improved support of oss/sndio.


https://github.com/trueos/freebsd-ports/commit/0576b2b7c846bd30ec6a5156bc3b0cd8bf476d56
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-02 11:18:52 UTC
You should also report this to OpenAL. They are very responsive. You should suggest them to make a release that doesn't crash.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-02 11:22:15 UTC
The thing is that OpenAL is a major package. Picking some intermediate version might make other things crash.
Comment 3 strangeqargo 2018-03-02 11:38:25 UTC
(In reply to Yuri Victorovich from comment #1)
It is tagged as https://github.com/kcat/openal-soft/tree/openal-soft-1.18.2

I can ask if they consider as stable though.
Comment 4 ken 2018-03-02 13:12:48 UTC
(In reply to Yuri Victorovich from comment #2)
The version getting pulled from GitHub is not an intermediate version, it is just using the GitHub tag to fetch the official 1.18.2 release (See the "Releases" page on their GitHub repository: https://github.com/kcat/openal-soft/releases )
The mechanism was just switched to pulling the release files from GitHub (which provides tracking of commits and changes since the release) instead of a static tarball from some project-hosted apache server.
Comment 5 strangeqargo 2018-03-02 13:56:49 UTC
(In reply to ken from comment #4)
our patches are already applied in openal-soft upstream, just in case:

- https://github.com/kcat/openal-soft/pull/171 
- https://github.com/kcat/openal-soft/pull/170
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-02 21:58:01 UTC
(In reply to strangeqargo from comment #5)

Ok, thanks, I will test some more and will update.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-03 06:39:44 UTC
(In reply to strangeqargo from comment #5)

Both pull requests correct build problems, not SEGVs.
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-04 06:01:48 UTC
(In reply to strangeqargo from comment #0)

There is some mistake here. You said that "TrueOS integrated newer version". TrueOS uses ce6076091bac3c00cd10803916e8911495580bd0, but git says that this is the same version that we have:

> $ git describe --tags ce6076091bac3c00cd10803916e8911495580bd0
> openal-soft-1.18.2
Comment 9 strangeqargo 2018-03-04 19:32:17 UTC
- those patches we sent are applied to master (which is good for future upgrades)

what is strange - 

- the bugs we encountered with openal-soft dependent apps seems fixed both in the lastest master and in 1.18.2 which (git diffed) is the same version which is downloaded from their website.

These segfaults manifested not only on my system, and with clean VMs..  the only explanation I have is that maybe there was some change (driver update?) in the FreeBSD codebase during those days (between our fixes and bugzilla submission)  which caused this buggy behaviour to disappear even with older version? 

Anyway, I'll check it once more, to be sure there are no such segfaults in latest FreeBSD/TrueOS builds, and if they disappeared, maybe there's no immediate reason to do something, apart from upgrading per se.
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-04 19:45:13 UTC
(In reply to strangeqargo from comment #9)

You've suggested that TrueOS has the desired version, but FreeBSD uses the same exact version.

You need to ask OpenAL to make a release with all changes.
Comment 11 Ivan 2018-04-24 19:38:27 UTC
I'm digging into segfault of telegram-desktop under my laptop (11-STABLE). Is this stack trace looks related to this issue?

(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x0000000803c9a092 in alcGetString () from /usr/local/lib/libopenal.so.1
#2  0x00000000017997b3 in Media::Audio::Start ()
#3  0x000000000176e3ec in Media::Player::start ()
#4  0x0000000001be1979 in Messenger::Messenger ()
#5  0x0000000001b58181 in Application::createMessenger ()
#6  0x0000000001b56777 in Sandbox::launch ()
#7  0x0000000001b55d7b in Application::socketError ()
#8  0x000000080889d30e in QMetaObject::activate () from /usr/local/lib/qt5/libQt5Core.so.5
#9  0x0000000806da9370 in QLocalSocket::error () from /usr/local/lib/qt5/libQt5Network.so.5
#10 0x0000000806daaa54 in QLocalServer::qt_metacall () from /usr/local/lib/qt5/libQt5Network.so.5
#11 0x0000000806dab182 in QLocalSocket::connectToServer ()
   from /usr/local/lib/qt5/libQt5Network.so.5
#12 0x0000000806da8b59 in QLocalSocket::connectToServer ()
   from /usr/local/lib/qt5/libQt5Network.so.5
#13 0x0000000001b54677 in Application::Application ()
#14 0x00000000012688ae in Core::Launcher::executeApplication ()
#15 0x000000000126865e in Core::Launcher::exec ()
#16 0x0000000001b70267 in main ()
Comment 12 Tobias Kortkamp freebsd_committer freebsd_triage 2018-06-21 07:18:36 UTC
(In reply to Ivan from comment #11)
Yes, looks related.

What are the options you build openal-soft with?  Could you try updating it
to ports r472956 and see if the crashes go away?
Comment 13 Ivan 2018-06-21 08:27:12 UTC
Yes, it was SNDIO and OSS issue fixed in the commit. 
Thanks, Tobias!
Comment 14 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-11 11:00:19 UTC
openal-soft was updated to 1.19.0 in ports r479520 and the
segfaults related to device enumeration should be gone.