Bug 226385 - net/samba47 requires conditional assignment for SAMBA4_LDB
Summary: net/samba47 requires conditional assignment for SAMBA4_LDB
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-06 02:24 UTC by dewayne
Modified: 2018-03-06 03:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (timur)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2018-03-06 02:24:17 UTC 
Timur,
I suspect you intended SAMBA4_LDB to be assigned to one of 1.3, 1.2 or 1.1.  This minor change in Makefile enables that ;)

Index: /usr/ports/net/samba47/Makefile
===================================================================
--- /usr/ports/net/samba47/Makefile     (revision 463683)
+++ /usr/ports/net/samba47/Makefile     (working copy)
@@ -155,7 +155,7 @@
 RUN_DEPENDS+=                  tdb>=1.3.14:databases/tdb
 SAMBA4_BUNDLED_LIBS+=          !tdb,!pytdb
 # ldb
-SAMBA4_LDB=                    12
+SAMBA4_LDB?=                   12
 .if !defined(SAMBA4_LDB) || ${SAMBA4_LDB} == 13
 BUILD_DEPENDS+=                        ldb13>=1.3.0:databases/ldb13
 RUN_DEPENDS+=                  ldb13>=1.3.0:databases/ldb13

Though it crossed my mind to move the option to /usr/ports/Mk/bsd.default-versions.mk via DEFAULT_VERSIONS+= but ...
Comment 1 Timur I. Bakeyev freebsd_committer freebsd_triage 2018-03-06 03:06:06 UTC 
(In reply to dewayne from comment #0)
Hi, Dewayne!

Thanks for the support and attention to the details!

In this particular case this is an intentional config, to be able to share as much port code base between samba47 and samba48 and samba4-devel.

As you can imagine they are quite similar and mostly are copies of each other.

Samba 4.7 has to be linked with ldb12, as well as Samba 4.8 meant to the ldb13 only. Previous versions of Samba have to stick to ldb, but those are going to be expired pretty soon.

Actually, such a situation made me think that it's better to use bundled ldb, so samba4-devel is now have a choice to link with 1.3 or bundled ldb. So, this selection is purely for convenience of maintenance :) But nice you've asked :)