Bug 226608 - mail/crm114 - gettext and iconv dependencies are surplus
Summary: mail/crm114 - gettext and iconv dependencies are surplus
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Matthias Andree
Depends on:
Reported: 2018-03-14 16:22 UTC by Igor Sysoev
Modified: 2019-10-21 18:40 UTC (History)
2 users (show)

See Also:
chalpin: maintainer-feedback+

Proposed patch. (1019 bytes, patch)
2019-09-08 17:48 UTC, Corey Halpin
no flags Details | Diff
Removed gettext-runtime dependence. (475 bytes, patch)
2019-09-14 09:10 UTC, Igor Sysoev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Sysoev 2018-03-14 16:22:28 UTC
It seems that gettext and iconv dependencies are not required to build for mail/crm114 port.
Comment 1 Matthias Andree freebsd_committer 2019-09-07 20:09:41 UTC
Corey, any opinion?
Comment 2 Corey Halpin 2019-09-08 17:48:31 UTC
Created attachment 207298 [details]
Proposed patch.
Comment 3 Corey Halpin 2019-09-08 17:48:56 UTC
As far as I can tell, the iconv dependency is indeed superfluous at this point. (From the svn logs at https://svnweb.freebsd.org/ports/head/mail/crm114/Makefile?revision=101979&view=markup that dependency has been present since the port was created. I'm not sure if it was needed at some point or if it's always been superfluous).

However, the crm114 binary links libintl and so the port needs at least gettext-runtime, but probably not gettext itself.

The attached patch removes the iconv dependency and replaces gettext with gettext-runtime. It passes poudriere testport and works in the testing I've done. However, it's been some years since I used crm114. So the testing I did consisted of installing it and filtering a single message.

For that reason, the attached patch also drops my maintainership.
Comment 4 commit-hook freebsd_committer 2019-09-08 20:39:14 UTC
A commit references this bug:

Author: mandree
Date: Sun Sep  8 20:38:50 UTC 2019
New revision: 511596
URL: https://svnweb.freebsd.org/changeset/ports/511596

  Reduce number of requisites.

  Corey has decided to give up maintainership. Thanks for your past efforts!

  While here, run ${STRIP_CMD} on executables in bin/.

  PR:		226608
  Submitted by:	Corey Halpin (maintainer)
  Reported by:	Igor Sysoev

Comment 5 Matthias Andree freebsd_committer 2019-09-08 20:41:48 UTC
I've also added a ${STRIP_CMD} to the post-install to conform to ports framework conventions.
Comment 6 Igor Sysoev 2019-09-14 09:10:23 UTC
Created attachment 207484 [details]
Removed gettext-runtime dependence.

Thank you for your work.

It seems however that crm114 does not use gettext-runtime at all.
There are no dependencies on the library inside crm114 and it is
linked and works successfully without libintl:

	libtre.so.5 => /usr/local/lib/libtre.so.5 (0x800894000)
	libm.so.5 => /lib/libm.so.5 (0x800aa7000)
	libc.so.7 => /lib/libc.so.7 (0x800cd7000)

The attached patch removes gettext-runtime dependencies.
Comment 7 Matthias Andree freebsd_committer 2019-09-14 11:46:45 UTC
(In reply to Igor Sysoev from comment #6)
please see comment #3 and argue if this is true for all ports-supported FreeBSD versions.
Comment 8 Igor Sysoev 2019-09-14 17:50:44 UTC
(In reply to Matthias Andree from comment #7)

I can only state that the latest version of crm114-20100106-BlameMichelson.src.tar.gz does not contain any occurences of "libintl", "gettext", "textdomain" used in gettext API.
Comment 9 commit-hook freebsd_committer 2019-10-21 18:40:24 UTC
A commit references this bug:

Author: mandree
Date: Mon Oct 21 18:39:30 UTC 2019
New revision: 515119
URL: https://svnweb.freebsd.org/changeset/ports/515119

  mail/crm114: strip gettext-runtime requisite

  PR:		226608
  Reported by:	Igor Sysoev