Bug 226799 - The deskutils/ical port fails to build in latest 12.0-CURRENT
Summary: The deskutils/ical port fails to build in latest 12.0-CURRENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-20 15:15 UTC by bob
Modified: 2018-07-07 15:39 UTC (History)
4 users (show)

See Also:


Attachments
Output file from a make of deskutils/ical (693.57 KB, text/plain)
2018-03-20 15:15 UTC, bob
no flags Details
[patch] fix the compilation problems (10.84 KB, patch)
2018-03-21 20:57 UTC, J.R. Oldroyd
no flags Details | Diff
[patch] clean up all remaining compilation warnings (13.50 KB, patch)
2018-03-23 16:26 UTC, J.R. Oldroyd
fbsd: maintainer-approval+
Details | Diff
[patch] clean up all remaining compilation warnings (26.83 KB, patch)
2018-03-23 16:35 UTC, J.R. Oldroyd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bob 2018-03-20 15:15:02 UTC
Created attachment 191659 [details]
Output file from a make of deskutils/ical

On my 12.0-CURRENT system:
FreeBSD tavion.austin.ibm.com 12.0-CURRENT FreeBSD 12.0-CURRENT #1 r331115: Sun Mar 18 06:58:19 CDT 2018     bob@anakin.immure.com:/usr/obj/usr/src/amd64.amd64/sys/ANIKIN  amd64

Attempting to build deskutils/ical fails with lots of warnings and errors. Here's the final summary output (the full make output file attached):

fatal error: too many errors emitted, stopping now [-ferror-limit=]
3836 warnings and 20 errors generated.
*** [main.o] Error code 1

make[1]: stopped in /usr/ports/deskutils/ical/work/ical-2.2
--- time/libtime.a ---
A failure has been detected in another branch of the parallel make

make[2]: stopped in /usr/ports/deskutils/ical/work/ical-2.2/time
*** [time/libtime.a] Error code 2

make[1]: stopped in /usr/ports/deskutils/ical/work/ical-2.2
--- cal_tcl.o ---
67 warnings generated.
--- calendar/libcalendar.a ---
A failure has been detected in another branch of the parallel make

make[2]: stopped in /usr/ports/deskutils/ical/work/ical-2.2/calendar
*** [calendar/libcalendar.a] Error code 2

make[1]: stopped in /usr/ports/deskutils/ical/work/ical-2.2
3 errors

make[1]: stopped in /usr/ports/deskutils/ical/work/ical-2.2
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/deskutils/ical
Comment 1 J.R. Oldroyd 2018-03-21 20:57:22 UTC
Created attachment 191722 [details]
[patch] fix the compilation problems

Also take maintainership.
Comment 2 bob 2018-03-22 21:12:11 UTC
I attempted to install the patch that J.R. Oldroyd provided but it fails to install

It creates a bunch of patch-bitmaps files in the deskutils/ical directory and
finally stops waiting on this:

|diff -ruN /usr/ports/deskutils/ical/files/patch-main.C deskutils/ical/files/patch-main.C
|--- /usr/ports/deskutils/ical/files/patch-main.C       2018-03-21 16:50:15.215144000 -0400
|+++ deskutils/ical/files/patch-main.C  2018-03-21 16:41:39.927260000 -0400
--------------------------
File to patch: 


So, what am I doing wrong here? Any clues?

Thanks,
Bob
Comment 3 Walter Schwarzenfeld 2018-03-23 15:18:51 UTC
=> |--- /usr/ports/deskutils/ical/files/patch-main.C  

/usr/ports should not in this line.
Comment 4 Walter Schwarzenfeld 2018-03-23 15:26:53 UTC
Was not exact, depends on from which directory you patch it. 
If you are in the port it cannot find the path beginning with deskutils/ical. You had to cd to /usr/ports
and patch it from there. Or you remove deskutils/ical from all pathes and you can patch it in the port.
Comment 5 J.R. Oldroyd 2018-03-23 15:37:13 UTC
Or, if you're in the deskutils/ical directory:
  patch -p2 <ical-2.2_5.diff
Comment 6 J.R. Oldroyd 2018-03-23 16:26:48 UTC
Created attachment 191755 [details]
[patch] clean up all remaining compilation warnings

Additional 2.2_6 patch, which should be applied after the 2.2_5 patch, which cleans up all remaining compilation warnings.
Comment 7 J.R. Oldroyd 2018-03-23 16:35:12 UTC
Created attachment 191756 [details]
[patch] clean up all remaining compilation warnings

Reroll of the 2.2_6 patch after running portlint.
Comment 8 bob 2018-04-27 15:17:18 UTC
I was wondering what the status for the patch/fix is for this problem? Is there an ETA for when it will be committed?
Comment 9 david 2018-05-28 18:00:22 UTC
I am seeing similar failures attempting to build ical-2.2_4 via poudriere in a stable/11 (amd64) environment, most recently:

FreeBSD freebeast.catwhisker.org 11.2-BETA3 FreeBSD 11.2-BETA3 #697  r334246M/334253:1101515: Sun May 27 03:39:35 PDT 2018     root@freebeast.catwhisker.org:/common/S1/obj/usr/src/sys/GENERIC  amd64

I can provide the log from the failed build; I hesitate only because I believe it would be redundant at this point.
Comment 10 commit-hook freebsd_committer freebsd_triage 2018-07-07 15:36:41 UTC
A commit references this bug:

Author: tobik
Date: Sat Jul  7 15:35:41 UTC 2018
New revision: 474101
URL: https://svnweb.freebsd.org/changeset/ports/474101

Log:
  desktuils/ical: Fix build with Clang 6

  - Submitter becomes maintainer
  - While here add missing dependencies

  http://beefy11.nyi.freebsd.org/data/head-i386-default/p473790_s335878/logs/ical-2.2_4.log

  PR:		226799
  Reported by:	bob@immure.com
  Submitted by:	fbsd@opal.com

Changes:
  head/deskutils/ical/Makefile
  head/deskutils/ical/files/patch-Makefile.in
  head/deskutils/ical/files/patch-bitmaps-dleft.xbm
  head/deskutils/ical/files/patch-bitmaps-done.xbm
  head/deskutils/ical/files/patch-bitmaps-dright.xbm
  head/deskutils/ical/files/patch-bitmaps-ical.xbm
  head/deskutils/ical/files/patch-bitmaps-left.xbm
  head/deskutils/ical/files/patch-bitmaps-right.xbm
  head/deskutils/ical/files/patch-bitmaps-sleft.xbm
  head/deskutils/ical/files/patch-bitmaps-sright.xbm
  head/deskutils/ical/files/patch-bitmaps-todo.xbm
  head/deskutils/ical/files/patch-cal_tcl.C
  head/deskutils/ical/files/patch-calendar_Makefile.in
  head/deskutils/ical/files/patch-calendar_calendar.C
  head/deskutils/ical/files/patch-calendar_calfile.C
  head/deskutils/ical/files/patch-config.h.in
  head/deskutils/ical/files/patch-dateeditor.C
  head/deskutils/ical/files/patch-dispatch.C
  head/deskutils/ical/files/patch-ical.h
  head/deskutils/ical/files/patch-item_tcl.C
  head/deskutils/ical/files/patch-main.C
  head/deskutils/ical/files/patch-object.C
  head/deskutils/ical/files/patch-pref.tcl
  head/deskutils/ical/files/patch-time_Makefile.in
  head/deskutils/ical/files/patch-time_tcl.C
  head/deskutils/ical/files/patch-types_Makefile.in