Bug 227120 - [NEW PORT] net-mgmt/carbon-c-relay: daemon written in C that acts as a relay
Summary: [NEW PORT] net-mgmt/carbon-c-relay: daemon written in C that acts as a relay
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-03-30 19:09 UTC by Andreas Andersson
Modified: 2019-03-13 12:41 UTC (History)
2 users (show)

See Also:
tobik: maintainer-feedback-

Attachments
net-mgmt/carbon-c-relay (6.46 KB, patch)
2018-03-30 19:09 UTC, Andreas Andersson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Andersson 2018-03-30 19:09:05 UTC 
Created attachment 191986 [details]
net-mgmt/carbon-c-relay

This brings net-mgmt/carbon-c-relay. https://github.com/grobian/carbon-c-relay

 It is a daemon written in C that acts as a relay. It supports a few different hashing algorithms: carbon_ch, fnv1a_ch and jump_fnv1a_ch. And ontop of that it can do replication. It has the support of relaying to multiple clusters of carbon as well, can do aggregations and much more.


In this port I decided to rename the compiled binary from `relay` to `carbon-c-relay`, this was done to avoid collisions with any current or future ports that might use the same name for the binary.

Poudriere QA fine on 10.3, 10.4, 11.1 and 12-CURRENT. portlint -AC also fine. As well as already running in production at work.

Please let me know if there's any improvements I can do to the port. :)
Comment 1 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-04-10 08:14:26 UTC 
took :)
Comment 2 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-04-10 12:11:58 UTC 
Shouldn't the port have any conflict with the already-existing carbon-relay-ng IYO? 
[Just asking, didn't tested yet]
Comment 3 Andreas Andersson 2018-04-10 12:18:53 UTC 
(In reply to Mahdi Mokhtari from comment #2)
Not it shouldn't. I am the port matainer of the other port as well. :)

Ontop of that this is a single binary that I renamed to carbon-c-relay, just to avoid any current or future exectuable name collisions. :)
Comment 4 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-04-10 13:48:49 UTC 
(In reply to Andreas Andersson from comment #3)
Aha, Ok :)
To make it clear, yeh I knew you also maintain the other port (it was actually the reason I asked the question from you :D)...

So anyway,
I'd like to suggest a couple of things on your patch: 
- etc/${PORTNAME} can be "${ETCDIR}
- changing the relay.conf file to relay.conf.sample and let the pkg-plist handler install it as well as keeping the .sample on upgrades/...
-[Wouldn't the reasoning behind changing the name of bin/relay also applies to etc/relay.conf as well? if yes I'd suggest patching the makefiles totally for all usages of the name]

Except these, everything seems to me fine so far :)
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2019-02-26 07:54:37 UTC 
This seems to be stalled and is 2 releases out of date now.  Do we
close?
Comment 6 Mahdi Mokhtari freebsd_committer freebsd_triage 2019-02-26 13:08:16 UTC 
(In reply to Tobias Kortkamp from comment #5)
Not sure, maybe set a feedback-timeout by reporter/maintainer before closing it?
[In case they'll update it and resubmit it]
Comment 7 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-13 12:41:25 UTC 
Closing after 2 more weeks of no feedback.