Bug 227131 - net/wireshark: port improvements (lz4/nghttp2/snappy weren't actually used, …)
Summary: net/wireshark: port improvements (lz4/nghttp2/snappy weren't actually used, …)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-31 11:11 UTC by Greg V
Modified: 2018-04-08 15:48 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
wireshark.patch (2.01 KB, patch)
2018-03-31 11:11 UTC, Greg V
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg V 2018-03-31 11:11:56 UTC
Created attachment 191999 [details]
wireshark.patch

So I just installed net/wireshark, opened the About box and noticed that it said "without nghttp2, without lz4, without snappy".

Added --with-* for these libs, and it complained about not finding headers…

So, USES=localbase is required. (instead of only adding -I${LOCALBASE}/include for the RTP option)

I also left the --with flags in the patch just to always make sure these libraries are used (e.g. if someone tries to turn off localbase again.)

Plus, ipv6 and gcrypt are not options (anymore?), they're hard requirements. (configure was warning about unknown flags).
Comment 1 Joe Marcus Clarke freebsd_committer 2018-04-08 15:47:36 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2018-04-08 15:48:02 UTC
A commit references this bug:

Author: marcus
Date: Sun Apr  8 15:47:16 UTC 2018
New revision: 466804
URL: https://svnweb.freebsd.org/changeset/ports/466804

Log:
  Update to 2.4.6.

  See
  https://www.wireshark.org/docs/relnotes/wireshark-2.4.6.html for a list of
  changes in this release.

  Additionally, fix the following issues in the Makefile [1]:

  * Add missing --with-* for lz4, snappy, and nghttp2
  * Remove obsolete --with-* for IPv6 and gcrypt
  * Use localbase

  PR:		227131 [1]
  Submitted by:	Greg V <greg@unrelenting.technology> [1]

Changes:
  head/net/wireshark/Makefile
  head/net/wireshark/distinfo
  head/net/wireshark/pkg-plist