Created attachment 192129 [details] Patch adding support for the new ${name}_limits mechanics (databases/mongodb34-rocks) Thanks to the recent change to rc.subr(8) it is no longer necessary to define a resource limiting logic in service scripts. limits(1) is now run by default and its configuration is handled via the "${name}_limits" variable. Unfortunately, there is a collision of variable names. The service scripts are broken on FreeBSD version with that new change (12.0-CURRENT, 11-STABLE and soon 11.2-RELEASE). It has been reported and diagnosed here.[2] I'm submitting a patch fixing the service script for this port. A similar patch has already been accepted by a maintainer of another database port.[2] The patch preserves the old behavior on the systems without the modification. It would be great if you could review the patch and test it. :) [1]: https://svnweb.freebsd.org/base?view=revision&revision=r328331 [2]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226907
Created attachment 192220 [details] Patch adding support for the new ${name}_limits mechanics (databases/mongodb34-rocks, revision: 1) The previous patch would fail to trigger the new ${name}_limits semantics for __FreeBSD_version 1101514. The new patch fixes it (thanks to mmokhi@).
Created attachment 192406 [details] Patch adding support for the new ${name}_limits mechanics (databases/mongodb34-rocks, revision: 4) Due to an increasing number of problems caused by the new ${name}_limits behavior, the revision, which was backported from 12-CURRENT to 11-STABLE, has now been reverted.[1] As a result, the new behavior will not be present in any FreeBSD version < 12. This new patch adapts the port to those latest changes. [1]: https://svnweb.freebsd.org/base?view=revision&revision=r332363
... c++ -o build/opt/third_party/yaml-cpp-0.5.3/src/nodebuilder.o -c -pipe -march=sandybridge -g -fstack-protector -fno-strict-aliasing -Woverloaded-virtual -Wpessimizing-move -Wredundant-move -Wno-undefined-var-template -stdlib=libc++ -std=c++11 -pipe -march=sandybridge -g -fstack-protector -fno-strict-aliasing -fno-omit-frame-pointer -fno-omit-frame-pointer -fno-strict-aliasing -ggdb -pthread -Wall -Wsign-compare -Wno-unknown-pragmas -Winvalid-pch -Wno-unused-local-typedefs -Wno-unused-function -Wno-unused-private-field -Wno-deprecated-declarations -Wno-tautological-constant-out-of-range-compare -Wno-unused-const-variable -Wno-missing-braces -Wno-inconsistent-missing-override -Wno-potentially-evaluated-expression -fstack-protector-strong -fno-builtin-memcmp -fpic -DNDEBUG -DBOOST_THREAD_VERSION=4 -DBOOST_THREAD_DONT_PROVIDE_VARIADIC_THREAD -DBOOST_SYSTEM_NO_DEPRECATED -Isrc/third_party/yaml-cpp-0.5.3/include -I/usr/local/include src/third_party/yaml-cpp-0.5.3/src/nodebuilder.cpp 1 error generated. scons: *** [build/opt/third_party/yaml-cpp-0.5.3/src/convert.o] Error 1 In file included from src/third_party/yaml-cpp-0.5.3/src/memory.cpp:2: In file included from src/third_party/yaml-cpp-0.5.3/include/yaml-cpp/node/detail/node.h:14: In file included from src/third_party/yaml-cpp-0.5.3/include/yaml-cpp/node/detail/node_ref.h:13: In file included from src/third_party/yaml-cpp-0.5.3/include/yaml-cpp/node/detail/node_data.h:20: In file included from src/third_party/yaml-cpp-0.5.3/include/yaml-cpp/node/iterator.h:13: src/third_party/yaml-cpp-0.5.3/include/yaml-cpp/node/detail/iterator.h:48:54: error: no member named 'next' in namespace 'boost' void increment() { this->base_reference() = boost::next(this->base()); } ~~~~~~~^ 1 error generated. ...
(In reply to Thomas Zander from comment #3) I am sure that this error is not caused by the provided patch. I guess that this port requires some fixing due to the recent updates to the C++ toolchain. :/
This port expired today, is there any news on fixing this?
No news, expired port removed, still available in 2018Q3 branch