Created attachment 192160 [details] mod_security3-3.0.1.patch The attached patch updates the www/mod_security3 port to version 3.0.1.
Maintainer informed via mail
Thank you for the contribution Marius Could you please update either your Bugzilla email to match that set in the ports MAINTAINER line (or vice versa), so that we and the bugzilla auto-assigner system can set appropriate and correct fields values when changes are submitted for your ports, and so we can verify maintainer ship.
A couple of review items while we're here: - Use DISTVERSIONPREFIX=v instead of setting GH_TAGNAME which defaults to DISTVERSIONFULL, which will include the v - Is it expected that the shared library version went backwards for a point release? In either case, is there anything else that needs to be done for dependent ports (if any) to see the change? Might be worth checking with upstream whether this was intentional
(In reply to Kubilay Kocak from comment #2) Thanks for letting me know, I've change my email here. (In reply to Kubilay Kocak from comment #3) > - Use DISTVERSIONPREFIX=v instead of setting GH_TAGNAME which defaults to DISTVERSIONFULL, which will include the v I'll look into this. > - Is it expected that the shared library version went backwards for a point release? In either case, is there anything else that needs to be done for dependent ports (if any) to see the change? Might be worth checking with upstream whether this was intentional This is a known bug, it will be fixed when they release 3.0.2, but I'm not sure when that will happen.
Created attachment 192164 [details] mod_security3-3.0.1.patch I have updated the patch use DISTVERSIONPREFIX, and while at it I took the liberty of adding the commit which fixes the library version numbering for now.
Created attachment 192203 [details] mod_security3-3.0.2.patch Turns out 3.0.2 was just released. Here is an updated patch for 3.0.2 which doesn't need the extra patch files to get the library version right.
Moin Marius :-) Thanks for the update and the patch. I will commit this directly with an update for nginx. It takes another 1-2 days to test everything.
(In reply to Jochen Neumeister from comment #7) Thanks for letting me know.
Hey Marius, Excuse my late response. When I enable "DEVELOPER=yes", i see this error: ====> Compressing man pages (compress-man) ====> Running Q/A tests (stage-qa) Warning: 'lib/libmodsecurity.so.3.0.2' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Error: /usr/local/bin/modsec-rules-check is linked to /usr/local/lib/libmaxminddb.so.0 from net/libmaxminddb but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libmaxminddb.so:net/libmaxminddb root@nginx-testbuild:/usr/ports/www/mod_security3 # can you have a look at this Problem?
Created attachment 192828 [details] mod_security3-3.0.2.patch Hi, Thanks for the feedback, I've uploaded a new patch which fixes these. It seems like libmaxminddb is an optional dependency so I haven't run into any issues with it not being explicitly listed, but I've added it to the dependency list now.
i fix your patch. It lacked the pkg-plist: http://jochen.joneumbox.org/mod_security3.diff Now, the Problem: on amd64 there is no Problem: http://joneumbox.org/data/11-1-AMD64-ports/2018-04-27_20h30m27s/logs/mod_security3-3.0.2.log But on i386, poudriere stop with an error: http://joneumbox.org/data/11-1-i386-ports/2018-04-27_20h30m27s/logs/errors/mod_security3-3.0.2.log
A commit references this bug: Author: joneum Date: Sat Apr 28 16:03:37 UTC 2018 New revision: 468551 URL: https://svnweb.freebsd.org/changeset/ports/468551 Log: Update to 3.0.2 PR: 227245 Submitted by: Marius Halden <marius.halden@modirum.com> (maintainer) Changes: head/www/mod_security3/Makefile head/www/mod_security3/distinfo head/www/mod_security3/pkg-plist