Bug 227306 - Allow to use samba48 with USES=samba
Summary: Allow to use samba48 with USES=samba
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Port Management Team
URL:
Keywords: feature, patch
Depends on:
Blocks:
 
Reported: 2018-04-05 21:36 UTC by Vladimir Druzenko
Modified: 2018-05-05 08:43 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2018-04-05 21:36:19 UTC 
Need the same patch, but for samba 4.8: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224418
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2018-04-14 13:43:36 UTC 
Mk/Uses/samba.mk:
 SAMBAPORT=	net/samba${SAMBA_DEFAULT:S/.//}
 SAMBAINCLUDES=	${LOCALBASE}/include/samba4
-.if ${SAMBA_DEFAULT} == 4.4 || ${SAMBA_DEFAULT} == 4.5 || ${SAMBA_DEFAULT} == 4.6 || ${SAMBA_DEFAULT} == 4.7
+.if ${SAMBA_DEFAULT} == 4.4 || ${SAMBA_DEFAULT} == 4.5 || ${SAMBA_DEFAULT} == 4.6 || ${SAMBA_DEFAULT} == 4.7 || ${SAMBA_DEFAULT} == 4.8
 SAMBALIBS=	${LOCALBASE}/lib/samba4
 .else


Mk/bsd.default-versions.mk:
 PYTHON3_DEFAULT?=	3.6
 # Possible values: 2.3, 2.4, 2.5
 RUBY_DEFAULT?=		2.4
-# Possible values: 4.4, 4.5, 4.6, 4.7
+# Possible values: 4.4, 4.5, 4.6, 4.7, 4.8
 SAMBA_DEFAULT?=		4.6
 # Possible values: base, openssl, openssl-devel, libressl, libressl-devel
 .if !defined(SSL_DEFAULT)
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2018-05-05 07:00:13 UTC 
Can we get this in the tree?
Samba48 has been out for some time now.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2018-05-05 08:30:30 UTC 
This was committed 1 month ago.
Comment 4 Dries Michiels freebsd_committer freebsd_triage 2018-05-05 08:43:50 UTC 
Ah I see where I got the confusion,

https://svnweb.freebsd.org/ports/head/Mk/bsd.default-versions.mk?view=markup

The possible values entry didn't get updated in Mk/bsd.default-versions.mk

87 # Possible values: 4.4, 4.5, 4.6, 4.7
88 SAMBA_DEFAULT?=         4.6

Altough Mk/Uses/samba.mk did receive the update commit.