Bug 227807 - [NEW PORT] deskutils/py-khard An addressbook for the console.
Summary: [NEW PORT] deskutils/py-khard An addressbook for the console.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
URL: https://reviews.freebsd.org/D17491
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-27 14:22 UTC by Andreas Bilke
Modified: 2018-10-10 21:39 UTC (History)
3 users (show)

See Also:


Attachments
The port as a shar file. (3.02 KB, text/plain)
2018-04-27 14:22 UTC, Andreas Bilke
no flags Details
py-khard port (3.02 KB, text/plain)
2018-06-06 17:21 UTC, Andreas Bilke
no flags Details
Revised port, with additions from #4 (11.86 KB, text/plain)
2018-08-12 10:23 UTC, Andreas Bilke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Bilke 2018-04-27 14:22:29 UTC
Created attachment 192845 [details]
The port as a shar file.

I created my first port. It is py-khard, a console addressbook.
Comment 1 Thomas Merkel 2018-06-05 20:03:02 UTC
I've tried to build it but received an error that the filesize and sum doesn't match the downloaded file.

The following distinfo works for me:

TIMESTAMP = 1528228795
SHA256 (khard-0.12.2.tar.gz) = 9193d2d07cdb69cc6e35a0732111efb92bbfba854a1dd42b4f9c91a52a16c507
SIZE (khard-0.12.2.tar.gz) = 5064055
Comment 2 Andreas Bilke 2018-06-06 17:20:18 UTC
(In reply to Thomas Merkel from comment #1)

You are right. I had the .tar.gz from github in my distfiles directory for testing (and forgot that the sources will be fetched from pypi).

I will attach the corrected version.
Comment 3 Andreas Bilke 2018-06-06 17:21:00 UTC
Created attachment 194048 [details]
py-khard port
Comment 4 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-08-01 13:33:28 UTC
Hi.

A few things:

1 - when adding a new port you should also add it to its category Makefile ( aka /usr/ports/deskutils/Makefile )

2 - when installing example files please use the ${EXAMPLESDIR} macro ( see 5.16.3 of Porters Handbook ), and then you also don't need to create the khard subdirectory for it, just point to the original khard directory and the directory will be created by the ${COPYTREE_SHARE} macro

3 - use ${PY_FLAVOR} instead of ${FLAVOR}

4 - please add @sample before the sample file on PLIST_FILES ( see 8.6.9 on the Porter's Handbook )

5 - cosmetics: the tab spaces seem a bit excessive from here and many lines are not aligned. Also, I would break the PLIST_FILES lines in 2 lines to avoid a too long line.

Thanks! :)
Comment 5 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-08-01 13:47:05 UTC
Please, forget about the @sample thing. This is a example and not a config file. ^^

Btw, you are also missing the 'template_for_contact_creation.yaml' on PLIST_FILES. This will and as something like this:

PLIST_FILES=    share/zsh/site-functions/_khard \
                %%PORTEXAMPLES%%%%EXAMPLESDIR%%/khard.conf.example \
                %%PORTEXAMPLES%%%%EXAMPLESDIR%%/template_for_contact_creation.yam
Comment 6 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-08-07 03:31:14 UTC
You may also want to add deskutils/py-vdirsyncer to RUN_DEPENDS. :)
Comment 7 Andreas Bilke 2018-08-12 10:22:59 UTC
(In reply to Alexandre C. Guimarães from comment #4)

First of all, thank you for your guidance!

1. done
2. done
3. done
4. --
5. if I use tabstop=4 (as suggested in porter's handbook, chapter 2), the file looks aligned
6. template_for_contact_creation.yaml was added
7. RUN_DEPENDS was extended

I attached the revised version.
Comment 8 Andreas Bilke 2018-08-12 10:23:52 UTC
Created attachment 196121 [details]
Revised port, with additions from #4
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-10-10 21:36:20 UTC
A commit references this bug:

Author: rigoletto
Date: Wed Oct 10 21:36:04 UTC 2018
New revision: 481769
URL: https://svnweb.freebsd.org/changeset/ports/481769

Log:
  deskutils/py-khard: console carddav client. New port.

  PR:		227807
  Submitted by:	Andreas Bilke <freebsd.org@bilke.org>
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17491

Changes:
  head/deskutils/Makefile
  head/deskutils/py-khard/
  head/deskutils/py-khard/Makefile
  head/deskutils/py-khard/distinfo
  head/deskutils/py-khard/files/
  head/deskutils/py-khard/files/pkg-message.in
  head/deskutils/py-khard/pkg-descr
Comment 10 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-10-10 21:39:40 UTC
Thank you! :-)