Bug 227905 - `make po' does not update the *.po file
Summary: `make po' does not update the *.po file
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-doc (Nobody)
URL: https://reviews.freebsd.org/D15263
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-01 18:49 UTC by Wolfram Schneider
Modified: 2018-05-10 20:07 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfram Schneider freebsd_committer freebsd_triage 2018-05-01 18:49:03 UTC 
I got a report from a translation team that `make po' is not working anymore. If you run it for a second time the generated *.po file will never change.

I could reproduce this myself for doc/zh_TW.UTF-8/articles/leap-seconds
Comment 1 Wolfram Schneider freebsd_committer freebsd_triage 2018-05-01 18:52:59 UTC 
The problem may be started by this commit:

commit 916a887bbaf3f89f30f1920b52f9652d3d5a20c4
Author: wblock <wblock@FreeBSD.org>
Date:   Mon Aug 14 21:08:28 2017 +0000

    Trim obsolete translations from PO files.  These are translations for
    text which does not exist in the original English document any more.


The line
${MSGATTRIB} --no-obsolete -o ${PO_LANG}.po.new ${PO_LANG}.po

is using wrong parameters, it use the old *.po file as input (instead the new one) and overrides the fresh updated *.po with old data.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-05-10 20:06:59 UTC 
A commit references this bug:

Author: wosch
Date: Thu May 10 20:06:55 UTC 2018
New revision: 51638
URL: https://svnweb.freebsd.org/changeset/doc/51638

Log:
  Fix `make po' for updates

  PR:		227905
  Differential Revision:	https://reviews.freebsd.org/D15263

Changes:
  head/share/mk/doc.translate.mk