Created attachment 193239 [details] svn diff to fix databases/py-pyPgSQL databases/py-pyPgSQL is currently slated for the chopping block, due to a needed (remote) patch file being corrupt. The attached svn diff file corrects that problem, and several other issues with this port. CHANGES included in the attached svn diff (patch): o points to correct location of remote PATCHFILE o adds missing LICENSE o removes BROKEN o removes DEPRECATED o removes EXPIRATION_DATE o updates distinfo o changes MAINTAINER (to me) As to MAINTAINER; I maintain a port that depends on this port. I'd like to update my port to be available to Python-3.x users but this port doesn't support Python-3. So I checked out the CVS source for this port, and am converting it to a GIT repo that I will host on my GitLab account, and upgrade to make this Python-3 compatible. This port (source) hasn't been touched since ~2006. That's it. :-) Thanks! --Chris and for bonus points. I've included the output log to prove this works! :-)
Created attachment 193240 [details] output log to prove this patch works. :-) The output generated using this patch.
Thank you Chris. Could you please confirm QA (portlint, poudriere, etc) as well
Created attachment 193264 [details] updated svn diff for databases/py-pyPgSQL Updated svn diff for databases/py-pyPgSQL
Created attachment 193265 [details] QA LOG for databases/py-pyPgSQL Sure. Here's a transcript for the requested output. Thanks for taking the time to look at this! --Chris
A few other QA / improvement items (already made, no need to update patch unless you'd like to) - Use autoplist for python packages where possible. Also quells USE_LDCONFIG portlint warning. - Un-mute INSTALL_* commands (portlint warning with -AC) - Remove DATETIME_DEP in favour of a fully written out RUN_DEPENDS on the py-mx-base packagename Note: INSTALL_TARGET=install-strip only works for projects using Makefile's that implement an install-strip target. It will need to be stripped usign ${STRIP_CMD} /path/to/file.so
A commit references this bug: Author: koobs Date: Fri May 11 07:27:13 UTC 2018 New revision: 469614 URL: https://svnweb.freebsd.org/changeset/ports/469614 Log: databases/py-pyPgSQL: Unmark BROKEN, Update MAINTAINER This port was marked BROKEN/DEPRECATED due to a corrupt patch file. Update the patch source to fix the issue. Update MAINTAINER at submitters request. While here, level up ports / python port compliance: - Strip shared libraries - Use option helpers - Use python autoplist - Match upstream setup.py metadata (COMMENT) - Use explicit/canonical python package dependencies - Unmute INSTALL_* commands PR: 228119 Submitted by: Chris Hutchinson <portmaster bsdforge com> Approved by: koobs (python, maintainer) Changes: head/databases/py-pyPgSQL/Makefile head/databases/py-pyPgSQL/distinfo head/databases/py-pyPgSQL/pkg-plist
Committed with minor/compliance changes, thank you for fixing a deprecated/broken port and offering to take maintainership. Pending MFH
@Chris Separately I recommend taking the remote patch and producing a local files/patch-file for it so that the port can continue to be built/packaged without reliance on a third party server, for whatever reason.
(In reply to Kubilay Kocak from comment #8) > @Chris Separately I recommend taking the remote patch and producing a local > files/patch-file for it so that the port can continue to be built/packaged > without reliance on a third party server, for whatever reason. Thank you for all your time on this, Kubilay. I couldn't agree more. I had intended to do just that. But was so busy with cloning the CVS for this, and converting it to GIT. Then hosting it on my GitLab account. Then dealing with the port itself in it's current condition. I decided to wait, and roll that in on "phase 2" when I make it Python3 ready. Which I'm working on now. Thanks again, Kubilay! --Chris
A commit references this bug: Author: koobs Date: Fri May 18 03:36:35 UTC 2018 New revision: 470257 URL: https://svnweb.freebsd.org/changeset/ports/470257 Log: MFH: r469614 databases/py-pyPgSQL: Unmark BROKEN, Update MAINTAINER This port was marked BROKEN/DEPRECATED due to a corrupt patch file. Update the patch source to fix the issue. Update MAINTAINER at submitters request. While here, level up ports / python port compliance: - Strip shared libraries - Use option helpers - Use python autoplist - Match upstream setup.py metadata (COMMENT) - Use explicit/canonical python package dependencies - Unmute INSTALL_* commands PR: 228119 Submitted by: Chris Hutchinson <portmaster bsdforge com> Approved by: koobs (python, maintainer) Approved by: ports-secteam (riggs) Changes: _U branches/2018Q2/ branches/2018Q2/databases/py-pyPgSQL/Makefile branches/2018Q2/databases/py-pyPgSQL/distinfo branches/2018Q2/databases/py-pyPgSQL/pkg-plist