Bug 228327 - [PATCH] mail/p5-Email-Sender: replace deprecated prerequisite
Summary: [PATCH] mail/p5-Email-Sender: replace deprecated prerequisite
Status: Closed DUPLICATE of bug 233803
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-17 21:38 UTC by James E Keenan
Modified: 2019-01-04 18:17 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (bill.brinzer)

Attachments
Replace deprecated dependency p5-Email-Address with p5-Email-Address-XS (957 bytes, patch)
2018-05-17 21:38 UTC, James E Keenan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James E Keenan 2018-05-17 21:38:54 UTC 
Created attachment 193501 [details]
Replace deprecated dependency p5-Email-Address with p5-Email-Address-XS

While installing the mail/p5-Email-Sender package today, I got this output (tail):

#####
...
Extracting p5-Email-Sender-1.300011_1: 100%
Message from p5-Email-Address-1.909:

===>   NOTICE:

This port is deprecated; you may wish to reconsider installing it:

Deprecated by upstream.

It is scheduled to be removed on or after 2018-12-31.
#####

The upstream maintainer recommends substituting CPAN library Email-Address-XS for Email-Address.  There already is a FreeBSD port for that library: p5-Email-Address-XS.  So let's patch mail/p5-Email-Sender to reflect that.

Thank you very much.
Jim Keenan
Comment 1 James E Keenan 2018-05-18 00:04:38 UTC 
Let's put a pause on this port update request.

I have realized that we need to have Email-Sender changed upstream to 'use Email::Address::XS'.  Simply changing the port's Makefile is insufficient.  I have filed a pull request to that effect:  https://github.com/rjbs/Email-Sender/pull/59

Thank you very much.
Jim Keenan
Comment 2 Dan Langille freebsd_committer freebsd_triage 2018-11-19 13:56:16 UTC 
The upstream patch has been in the queue for 11 months.

I think that means it is not going to happen.
Comment 3 Dan Langille freebsd_committer freebsd_triage 2018-11-20 00:25:11 UTC 
I have forked the repo, have applied the patches.

https://github.com/dlangille/Email-Sender

It is not ready to go yet.
Comment 4 Dan Langille freebsd_committer freebsd_triage 2018-11-20 02:41:31 UTC 
My fork has been updated.

Proposed new patch for mail/p5-Email-Sender now at https://reviews.freebsd.org/D18053

Tested on my development instance of FreshPorts.  More testing requested please.
Comment 5 Dan Langille freebsd_committer freebsd_triage 2019-01-04 18:16:44 UTC 
I suspect we can close this now that https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233803 has added p5-Email-Address-XS
Comment 6 Dan Langille freebsd_committer freebsd_triage 2019-01-04 18:17:20 UTC 

*** This bug has been marked as a duplicate of bug 233803 ***