Bug 228428 - sysutils/py-google-compute-engine: fix hostname (patch)
Summary: sysutils/py-google-compute-engine: fix hostname (patch)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-05-22 17:43 UTC by Helen Koike
Modified: 2018-05-22 23:57 UTC (History)
3 users (show)

See Also:
helen.koike: maintainer-feedback+
helen.koike: merge-quarterly?


Attachments
Patch that fix py-google-compute-engine hostname generated using diff -u -r -N olddir newdir (3.97 KB, patch)
2018-05-22 17:43 UTC, Helen Koike
helen.koike: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helen Koike 2018-05-22 17:43:16 UTC
Created attachment 193622 [details]
Patch that fix py-google-compute-engine hostname generated using diff -u -r -N olddir newdir

In Google Cloud Engine, the hostname of a FreeBSD instance is not being set to the instance name, all the instances' hostname are being set to the same "freebsd" string, causing conflicts.

Please see attached patch that fixes the problem by including the script google_set_hostname [1] from upstream project in the /etc/dhcp-exit-hooks.

[1] https://github.com/GoogleCloudPlatform/compute-image-packages/blob/master/google_config/bin/google_set_hostname
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-05-22 23:52:50 UTC
A commit references this bug:

Author: swills
Date: Tue May 22 23:52:41 UTC 2018
New revision: 470666
URL: https://svnweb.freebsd.org/changeset/ports/470666

Log:
  sysutils/py-google-compute-engine: Fix hostname and bash usage

  PR:		228428
  PR:		228252
  Submitted by:	Helen Koike <helen.koike@collabora.com> (maintainer)

Changes:
  head/sysutils/py-google-compute-engine/Makefile
  head/sysutils/py-google-compute-engine/files/google_set_hostname
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_metadata__scripts_script__executor.py
  head/sysutils/py-google-compute-engine/pkg-plist
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-05-22 23:55:57 UTC
A commit references this bug:

Author: swills
Date: Tue May 22 23:54:59 UTC 2018
New revision: 470667
URL: https://svnweb.freebsd.org/changeset/ports/470667

Log:
  MFH: r470666

  sysutils/py-google-compute-engine: Fix hostname and bash usage

  PR:		228428
  PR:		228252
  Submitted by:	Helen Koike <helen.koike@collabora.com> (maintainer)

  Approved by:	ports-secteam (implicit)

Changes:
_U  branches/2018Q2/
  branches/2018Q2/sysutils/py-google-compute-engine/Makefile
  branches/2018Q2/sysutils/py-google-compute-engine/files/google_set_hostname
  branches/2018Q2/sysutils/py-google-compute-engine/files/patch-google__compute__engine_metadata__scripts_script__executor.py
  branches/2018Q2/sysutils/py-google-compute-engine/pkg-plist
Comment 3 Steve Wills freebsd_committer freebsd_triage 2018-05-22 23:57:04 UTC
Committed.

One PR for both issues would have been fine and easier to work with. Also, personally I find it easier to work with svn diffs or git diffs. See this page for more detail:

https://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html#svn-diff

Thanks for the fixes!