Bug 228608 - [NEW PORT] net/zmqpp: 0mq highlevel C++ bindings
Summary: [NEW PORT] net/zmqpp: 0mq highlevel C++ bindings
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2018-05-30 14:14 UTC by waitman
Modified: 2018-06-18 04:36 UTC (History)
2 users (show)

See Also:


Attachments
shar file for zmqpp port (4.49 KB, text/plain)
2018-05-30 14:14 UTC, waitman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description waitman 2018-05-30 14:14:16 UTC
Created attachment 193842 [details]
shar file for zmqpp port

not the same as cppzmq

This C++ binding for 0mq/zmq is a 'high-level' library that hides 
most of the c-style interface core 0mq provides.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-05-31 07:04:01 UTC
XMASTER_SITES=	https://github.com/zeromq/zmqpp/archive/
XDISTNAME=	${PORTVERSION}
[...]
XWRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}

This is bogus.  Please use USE_GITHUB and GH_ACCOUNT.  Then you
don't need to set WRKSRC and will automatically have a unique
distfile name.

Some other problems:

- Are you sure pathfix is needed?

- Why is patch-CMakeLists.txt needed?  Use CMAKE_OFF to turn off
  ZMQPP_BUILD_STATIC.

- It's building a shared library, so I highly doubt that NO_ARCH=yes
  is correct.

- The pkg-descr is too short.  Maybe include a general description of
  what zmq is or how zmqpp is different from cppzmq.

- Indentation in post-*: is off.  Only indent them with one tab.

- Either set PORTDOCS or include README.md in the plist but do not
  use both.

- Please provide some confirmation that this builds with Poudriere
  testport and passes portlint -AC.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-06-12 09:07:36 UTC
Ping.