Bug 228756 - sysutils/aimage: quiet pkg-fallout (make aimage package build)
Summary: sysutils/aimage: quiet pkg-fallout (make aimage package build)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-06-05 03:59 UTC by Chris Hutchinson
Modified: 2018-06-06 12:30 UTC (History)
1 user (show)

See Also:


Attachments
svn diff for sysutils/aimage - allows package building again (1.06 KB, patch)
2018-06-05 03:59 UTC, Chris Hutchinson
portmaster: maintainer-approval-
Details | Diff
QA LOG for sysutils/aimage (189.75 KB, text/plain)
2018-06-05 04:01 UTC, Chris Hutchinson
no flags Details
aimage.diff (2.38 KB, patch)
2018-06-05 08:24 UTC, Tobias Kortkamp
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2018-06-05 03:59:54 UTC
Created attachment 194009 [details]
svn diff for sysutils/aimage - allows package building again

pkg-fallout has been complaining for some time
(since llvm/clang 6 landed) about not being able to
build a sysutils/aiamge package.
This pr, and the accompanying svn diff fixes that.

Changes

Makefile -                   limit cc to llvm/clang version 5
files/patch-src_aimage.cpp - pet portlint

The limit to version 5 is only to allow packages to be
built, while I upgrade the ports source to allow building
with version 6.

Please also find a QA LOG attached to this pr.

That's it.

Thanks!

--Chris
Comment 1 Chris Hutchinson 2018-06-05 04:01:48 UTC
Created attachment 194010 [details]
QA LOG for sysutils/aimage

Proves the svn diff also attached to this pr(1) works! :-)

--Chris
Comment 2 Tobias Kortkamp freebsd_committer 2018-06-05 08:24:24 UTC
Created attachment 194011 [details]
aimage.diff

Hi Chris,

selecting an older compiler is not really sustainable in the long
term.  In aimage's case the fix is luckily trivial.  It tries to
call std::bind instead of bind(2) from the C library.  Applying a
small patch will fix that.

The patch also includes a fix to let it build on systems that use
LibreSSL.  I had trouble getting past the configure phase on my
workstation.

Poudriere test builds were fine on 10.4/i386, 11.1/amd64, 12.0/amd64
Comment 3 Chris Hutchinson 2018-06-05 19:26:19 UTC
Comment on attachment 194011 [details]
aimage.diff

Indeed @tobik. It was only intended as a short term solution.
As I have several backlogged pr(1)'s. I was just hoping to
get through them all, before taking a closer look, and improving
them *correctly*. :-)

Thank you *very* much for taking the time to resolve this
properly, Tobik!

Approved! :-)

--Chris
Comment 4 commit-hook freebsd_committer 2018-06-06 12:29:21 UTC
A commit references this bug:

Author: tobik
Date: Wed Jun  6 12:29:16 UTC 2018
New revision: 471840
URL: https://svnweb.freebsd.org/changeset/ports/471840

Log:
  sysutils/aimage: Unbreak build with Clang 6

  - Also fix build with LibreSSL: The configure script checks that
    libssl has ssl3_new() which LibreSSL doesn't have but aimage itself
    never uses it, so pretend it's there to pass the check.

  PR:		228756
  Reported by:	Chris Hutchinson <portmaster@bsdforge.com>
  Submitted by:	tobik
  Approved by:	Chris Hutchinson <portmaster@bsdforge.com> (maintainer)

Changes:
  head/sysutils/aimage/Makefile
  head/sysutils/aimage/files/patch-src_aimage.cpp
  head/sysutils/aimage/files/patch-src_imager.cpp
Comment 5 Tobias Kortkamp freebsd_committer 2018-06-06 12:30:10 UTC
Landed. Thanks!