Created attachment 194009 [details]
svn diff for sysutils/aimage - allows package building again
pkg-fallout has been complaining for some time
(since llvm/clang 6 landed) about not being able to
build a sysutils/aiamge package.
This pr, and the accompanying svn diff fixes that.
Makefile - limit cc to llvm/clang version 5
files/patch-src_aimage.cpp - pet portlint
The limit to version 5 is only to allow packages to be
built, while I upgrade the ports source to allow building
with version 6.
Please also find a QA LOG attached to this pr.
Created attachment 194010 [details]
QA LOG for sysutils/aimage
Proves the svn diff also attached to this pr(1) works! :-)
Created attachment 194011 [details]
selecting an older compiler is not really sustainable in the long
term. In aimage's case the fix is luckily trivial. It tries to
call std::bind instead of bind(2) from the C library. Applying a
small patch will fix that.
The patch also includes a fix to let it build on systems that use
LibreSSL. I had trouble getting past the configure phase on my
Poudriere test builds were fine on 10.4/i386, 11.1/amd64, 12.0/amd64
Comment on attachment 194011 [details]
Indeed @tobik. It was only intended as a short term solution.
As I have several backlogged pr(1)'s. I was just hoping to
get through them all, before taking a closer look, and improving
them *correctly*. :-)
Thank you *very* much for taking the time to resolve this
A commit references this bug:
Date: Wed Jun 6 12:29:16 UTC 2018
New revision: 471840
sysutils/aimage: Unbreak build with Clang 6
- Also fix build with LibreSSL: The configure script checks that
libssl has ssl3_new() which LibreSSL doesn't have but aimage itself
never uses it, so pretend it's there to pass the check.
Reported by: Chris Hutchinson <email@example.com>
Submitted by: tobik
Approved by: Chris Hutchinson <firstname.lastname@example.org> (maintainer)