Bug 228830 - deskutils/gucharmap: fails with latest UCD
Summary: deskutils/gucharmap: fails with latest UCD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-06-08 15:09 UTC by Christoph Moench-Tegeder
Modified: 2018-06-17 12:28 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback+

Attachments
patch to limit the generated unicode-versions.h to the version given on the command line (302 bytes, text/plain)
2018-06-08 15:09 UTC, Christoph Moench-Tegeder 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer freebsd_triage 2018-06-08 15:09:03 UTC 
Created attachment 194082 [details]
patch to limit the generated unicode-versions.h to the version given on the command line

After the update of textproc/UCD to 11.0 in ports r471937 , deskutils/gucharmap fails to build, with error messages like

./unicode-versions.h:111:21: error: use of undeclared identifier 'GUCHARMAP_UNICODE_VERSION_11_0'
  { 0x0560, 0x0560, GUCHARMAP_UNICODE_VERSION_11_0 },

Short digging shows that unicode-versions.h is autogenerated from textproc/UCD's DerivedAge.txt file by gucharmap/gen-guch-unicode-tables.pl. Unfortunately, this script builds unicode-versions.h with everything found in DerivedAge.txt, not capping it's output at the version given on it's command line.

The fix is rather simple - a one-line addition to gen-guch-unicode-tables.pl.
The attached file should be dropped into deskutils/gucharmap/files/ . It fixes the build of gucharmap in my poudriere.
Comment 1 Ting-Wei Lan 2018-06-09 02:21:25 UTC 
Link to the upstream issue: https://gitlab.gnome.org/GNOME/gucharmap/issues/1.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-06-09 17:16:33 UTC 
A commit references this bug:

Author: cmt
Date: Sat Jun  9 12:50:09 UTC 2018
New revision: 472052
URL: https://svnweb.freebsd.org/changeset/ports/472052

Log:
  unbreak deskutils/gucharmap after update of textproc/UCD

  gen-guch-unicode-tables.pl generated a unicode-versions.h file with
  all unicode versions found in UCD's DerivedAge.txt file - regardless
  of wether gucharmap itself supports that unicode version. This makes
  sure that codepoints with a higer unicode version than supported are
  skipped.

  PR:		228830
  Approved by:	maintainer (pi)

Changes:
  head/deskutils/gucharmap/files/
  head/deskutils/gucharmap/files/patch-gucharmap_gen-guch-unicode-tables.pl
Comment 3 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2018-06-09 19:37:20 UTC 
(In reply to Ting-Wei Lan from comment #1)
Vaguely related... breakage on a newer version of a dependency (here: UCD) should be avoided in any case.
Comment 4 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2018-06-09 19:37:50 UTC 
committed, thanks.
Comment 5 Ting-Wei Lan 2018-06-17 12:28:53 UTC 
gucharmap has been updated to support Unicode 11.0:
https://gitlab.gnome.org/GNOME/gucharmap/commit/d12ce7f7b58d6fa796726854dd2e660a2524b64a