Bug 228884 - audio/gradio: Minor fix in Makefile
Summary: audio/gradio: Minor fix in Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-06-11 11:00 UTC by Carlos J. Puga Medina
Modified: 2019-01-10 08:27 UTC (History)
1 user (show)

See Also:
arved: maintainer-feedback+

Attachments
patch (515 bytes, patch)
2018-06-11 11:00 UTC, Carlos J. Puga Medina 		no flags Details | Diff
patch-gradio (486 bytes, patch)
2019-01-09 18:17 UTC, Carlos J. Puga Medina 		cpm: maintainer-approval? (arved)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-06-11 11:00:22 UTC 
Created attachment 194155 [details]
patch

- Do not unnecessarily include bsd.port.pre.mk and bsd.port.post.mk
- Silence a explicitly called command
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2018-06-11 11:11:09 UTC 
I don't like to silence commands. I will commit the other change with the next update.
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-06-11 11:12:41 UTC 
(In reply to Tilman Keskinoz from comment #1)

OK, thank you Tilman :-)
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-01-09 18:17:52 UTC 
Created attachment 200963 [details]
patch-gradio

Update patch to include only bsd.port.mk
Comment 4 Tilman Keskinoz freebsd_committer freebsd_triage 2019-01-10 07:57:20 UTC 
looks good. I will not be able to commit it in the next two weeks, so go ahead.
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-01-10 08:26:42 UTC 
A commit references this bug:

Author: cpm
Date: Thu Jan 10 08:26:20 UTC 2019
New revision: 489850
URL: https://svnweb.freebsd.org/changeset/ports/489850

Log:
  - Do not unnecessarily include bsd.port.pre.mk and bsd.port.post.mk

  PR:		228884
  Submitted by:	cpm
  Approved by:	arved (maintainer)

Changes:
  head/audio/gradio/Makefile
Comment 6 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-01-10 08:27:10 UTC 
(In reply to Tilman Keskinoz from comment #4)

Committed, thanks!