Bug 228990 - mail/rspamd: needs to REQUIRE redis in init script
Summary: mail/rspamd: needs to REQUIRE redis in init script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vsevolod Stakhov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-13 16:28 UTC by Johan Bergström
Modified: 2018-09-20 18:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (vsevolod)


Attachments
patch (2.28 KB, patch)
2018-09-20 08:22 UTC, Alexander Moisseev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Bergström 2018-06-13 16:28:09 UTC
rspamd will be sad if redis functionality is used and it is unavailable. that is all.

fix:

# diff -u rspamd rspamd_fixed
--- rspamd	2018-06-13 18:27:35.475683000 +0200
+++ rspamd_fixed	2018-06-13 18:27:25.391718000 +0200
@@ -3,7 +3,7 @@
 # $FreeBSD: head/mail/rspamd/files/rspamd.in 420672 2016-08-23 12:41:19Z vsevolod $
 #
 # PROVIDE: rspamd
-# REQUIRE: LOGIN
+# REQUIRE: LOGIN redis
 # KEYWORD: shutdown
 #
 # Add the following line to /etc/rc.conf to enable rspamd:
Comment 1 Alexander Moisseev 2018-06-16 08:33:45 UTC
An MTA will be sad too if it could not connect to Rspamd milter.

Probably we should add "# BEFORE:  mail" as well.
Comment 2 Johan Bergström 2018-07-04 10:18:12 UTC
(In reply to Alexander Moisseev from comment #1)

SGTM. Should I attach a patch?
Comment 3 Alexander Moisseev 2018-09-20 08:22:28 UTC
Created attachment 197261 [details]
patch

- add more rcorder conditions
- move USES earlier
- sort pkg-plist
Comment 4 commit-hook freebsd_committer 2018-09-20 18:05:16 UTC
A commit references this bug:

Author: vsevolod
Date: Thu Sep 20 18:05:06 UTC 2018
New revision: 480186
URL: https://svnweb.freebsd.org/changeset/ports/480186

Log:
  - Add more rcorder conditions [2]
  - Move USES earlier [2]
  - Sort pkg-plist [2]

  PR:             228990
  Submitted by:   Johan Bergstrom <bugs@bergstroem.nu> [1], Alexander Moisseev [2]

Changes:
  head/mail/rspamd/Makefile
  head/mail/rspamd/files/rspamd.in
  head/mail/rspamd/pkg-plist