Bug 229044 - deskutils/spice-gtk: fix build with LibreSSL
Summary: deskutils/spice-gtk: fix build with LibreSSL
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-15 15:02 UTC by Piotr Kubaj
Modified: 2019-04-04 05:08 UTC (History)
4 users (show)

See Also:
xxjack12xx: maintainer-feedback+

Attachments
patch (3.18 KB, patch)
2018-06-15 15:02 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-06-15 15:02:11 UTC 
Created attachment 194274 [details]
patch

Tested on 11-STABLE, looks fine.
Comment 1 Jack 2018-06-15 20:08:55 UTC 
Didn't think libressl was still used so I removed it but this appears to work fine.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-06-15 22:49:31 UTC 
(In reply to xxjack12xx from comment #1)
Hm, why wouldn't LibreSSL be used? There are still security/libressl and security/libressl-devel ports, and they are well maintained, thanks to Bernard.
Comment 3 Jack 2018-06-15 23:14:12 UTC 
Maybe the right word is the libressl patching still needed since i already saw upstream already added a new ifdef in the existing code defined(LIBRESSL_VERSION_NUMBER)
but seems we need to make sure it only applies to that specific version. Will let the upstream know that they need to put < 0x20700000 in addition to if libressl is installed so we can get rid of our patch.
Comment 4 Walter Schwarzenfeld freebsd_triage 2019-03-31 14:23:11 UTC 
I tested 0.36 and it builds without problems with libressl.
Comment 5 Jack 2019-04-01 03:37:45 UTC 
Added new bug to upgrade the port

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236924
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2019-04-04 05:08:27 UTC 
0.36 build with LibreSSL.