Make index states on 10.4-RELEASE make_index: /usr/ports/editors/codelite: no entry for /usr/ports/devel/llvm39 Done. I think we could remove some lines from the Makefile: for v in 34 35 36 37 38 39 40 50 60 OPTIONS_RADIO_CLANG+= CLANG$v CLANG$v_DESC= Clang ${v:C/(.)(.)/\1.\2.x/} - .if $v >= 39 CLANG$v_BUILD_DEPENDS= llvm$v>0:devel/llvm$v CLANG$v_RUN_DEPENDS= llvm$v>0:devel/llvm$v .- else - CLANG$v_BUILD_DEPENDS= clang$v>0:lang/clang$v - CLANG$v_RUN_DEPENDS= clang$v>0:lang/clang$v - .endif
No was wrong, I think the change have to be: - .for v in 34 35 36 37 38 39 40 50 60 + .for v in 34 35 38 40 50 60 OPTIONS_RADIO_CLANG+= CLANG$v CLANG$v_DESC= Clang ${v:C/(.)(.)/\1.\2.x/} - .if $v >= 39 + .if $v >= 40 CLANG$v_BUILD_DEPENDS= llvm$v>0:devel/llvm$v CLANG$v_RUN_DEPENDS= llvm$v>0:devel/llvm$v .else CLANG$v_BUILD_DEPENDS= clang$v>0:lang/clang$v CLANG$v_RUN_DEPENDS= clang$v>0:lang/clang$v .endif
Hi, Thanks for reporting :) I wonder what's the reason behind not having llvm39 in our ports-tree `:D Anyway, gonna commit it ASAP
Another solution is to place the for loop after .include <bsd.port.options.mk>.
No, was wrong. Works with the index but not with the portdialog.
Created attachment 196224 [details] Remove support for obsolete clang versions Remove support for clang < 4.0. IMO this list isn't solving a real problem and it should be replaced with a single optional dependency on whatever version devel/mesalibs requires (currently devel/llvm60).
(In reply to Brooks Davis from comment #5) I obviously meant graphics/mesalibs above.
(In reply to Brooks Davis from comment #5) At first, Thanks for the patch :) Yup, I also think having different LLVMs in a loop is kinda ineffective, but IMO at the moment it's the "least POLA-violating" solution... I'd say if you are OK, let's go with something like that until we have some general "DEFAULT LLVM" on ports-framework (like mesa-libs port)... The problem with using mesa-libs (besides POLA-violation on users now) is its variable defined in gecko include-file, and I think it's not very well-shaped if we use it's USE in the codelite Makefile. So would you agree if we go with current-loop minues obsolete llvms and later we add LLVM generic supported/default versions to ports-framework or you think it's time to do it :) ?
I'd like to see the current patch committed as the port currently allows broken configurations. I don't like the loop because it will tend to leave people stuck on old versions and pointlessly building old LLVMs. It's also impossible to grep so if I forget about it I'll break the port again. Adding a USES=llvm is something we should do. If someone wants to pick it up, that would be great, otherwise it will likely remain on my todo list.
(In reply to Brooks Davis from comment #8) Ok, So I'll commit current one at the moment, But I have good time I think to work on the "USES" you suggested ;D Thanks again.
A commit references this bug: Author: mmokhi Date: Thu Aug 16 16:31:10 UTC 2018 New revision: 477359 URL: https://svnweb.freebsd.org/changeset/ports/477359 Log: editors/codelite: Remove support for obsolete clang versions PR: 229072 Submitted by: brooks Reported by: w.schwarzenfeld@utanet.at Sponsored by: The FreeBSD Foundation Changes: head/editors/codelite/Makefile
I just discovered that the patch was incomplete. You'll want this one too: Index: pkg-plist =================================================================== --- pkg-plist (revision 477360) +++ pkg-plist (working copy) @@ -9,10 +9,6 @@ bin/codelite_indexer bin/codelite_kill_children bin/codelite_xterm -%%CLANG37%%bin/codelite-lldb -%%CLANG37%%lib/codelite/LLDBDebugger.so -%%CLANG38%%bin/codelite-lldb -%%CLANG38%%lib/codelite/LLDBDebugger.so lib/codelite/AutoSave.so lib/codelite/CMakePlugin.so lib/codelite/CallGraph.so
A commit references this bug: Author: mmokhi Date: Thu Aug 16 16:38:36 UTC 2018 New revision: 477362 URL: https://svnweb.freebsd.org/changeset/ports/477362 Log: editors/codelite: Remove obsolete clang support from pkg-plist PR: 229072 Reported by: brooks Sponsored by: The FreeBSD Foundation Changes: head/editors/codelite/Makefile head/editors/codelite/pkg-plist
Thanks brooks for patch (and editing patch :D) and thanks w.schwarzenfeld for reporting.