Created attachment 194344 [details] Shell archive of the games/segs port submission This is a ports submission request for games/segs. SEGS is the Super Entity Game Server. It is a free, open-source (under the terms of the BSD License), cross-platform, and object- oriented suite of protocols and services designed to interface with popular super-hero themed MMORPG clients. SEGS is written in C++ and facilitates common MMORPG functionality such as account and character storage/retrieval using a database, secure client authentication, client movement in a virtual world, and chat. WWW: http://www.segs.io/ Project: http://github.com/Segs/Segs
Hi Lloyd, please consider some feedback. - There is an erroneous reference to "lang/qt5/lang" under LIB_DEPENDS; it should be lang/qt5-qml. - Eliminate the hard PREFIX; ports should always respect the user's PREFIX preference. Consider installing to %%PREFIX%%/%%PORTNAME%% instead. - There are excess tabs from aligning everything to DISTVERSIONPREFIX; remove a tab from each variable. - USES/USE_* should be after *_DEPENDS. There may be other issues that far more experienced eyes will catch.
Created attachment 194515 [details] Updated shell archive of games/segs ports submission
(In reply to Victor from comment #1) Thank you for catching the QML pathing issue, Victor. I've corrected that along with removing the extraneous tabs and adjusting the Makefile parameter order. As far as PREFIX is concerned, I've done something similar to security/rkhunter in regards to specifying the portname statically in pkg-plist. I've validated successful default installation to /usr/local/segs. An updated shar has been attached for your viewing pleasure. Thanks again for the feedback, sir.
Comment on attachment 194515 [details] Updated shell archive of games/segs ports submission All the libQt5* in LIB_DEPENDS and qt5-* SEGS_DEPENDS are already implied by USE_QT5. Note that USE_QT5 has also been renamed to USE_QT. See the Porter's Handbook [1] on how to migrate to it. Please also confirm that this passes portlint and a Poudriere testport. [1] https://www.freebsd.org/doc/en/books/porters-handbook/using-qt.html
Port was not rejected. Set close status to "Overcome By Events" as it seems to no longer be wanted in the ports tree.