Created attachment 194551 [details] Fix MSI allocation check for mps(4) and mpr(4) after r321714 Hello, already reported on freebsd-scsi@ (¹), I'd like to make sure this doesn't get lost. In r321714(²), which is part of MFC r322658(³), there's an unintended change that causes MSI allocation to be skipped in case MSI-X is not available. Please find attached a patch which I'm using for mps(4) on 11.2 and the same for mpr(4), which I haven't tested! (¹) https://lists.freebsd.org/pipermail/freebsd-scsi/2018-June/007743.html (²) https://svnweb.freebsd.org/base?view=revision&revision=321714 (³) https://svnweb.freebsd.org/base?view=revision&revision=322658
Author: scottl Date: Tue Nov 13 18:49:43 2018 New Revision: 340403 URL: https://svnweb.freebsd.org/changeset/base/340403 Log: Fix a regression from prior to 11.2 that caused MSI (not MSI-X) interrupt allocation to fail. While here, refactor the code so that it's more clear and less likely to break in the future. This is not an MFC due to the code in 12/head being very different, but it follows the latter's structure more closely than before.