Bug 229280 - ports-mgmt/portlint: Acknowledge target-OPTION-on/off
Summary: ports-mgmt/portlint: Acknowledge target-OPTION-on/off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-24 20:03 UTC by Adam Weinberger
Modified: 2018-09-16 17:53 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
target-OPTION-on (654 bytes, patch)
2018-06-24 20:03 UTC, Adam Weinberger 		no flags Details | Diff
Fixed options target patch (646 bytes, patch)
2018-09-06 13:36 UTC, Adam Weinberger 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2018-06-24 20:03:02 UTC 
Created attachment 194568 [details]
target-OPTION-on

Hi Joe!

Currently, portlint doesn't look for OPTION_NAME in a target, like:

post-patch-FOOBAR-on:

WARN: Makefile: FOOBAR is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MFOOBAR appears.

The attached patch adds a simple regex to look for it.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2018-09-05 16:38:46 UTC 
Thanks, Adam.  This diff looks funny to me.  Why is there a newline after the ':'?
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2018-09-06 13:36:23 UTC 
Created attachment 196915 [details]
Fixed options target patch

Yikes, I have no idea what happened there! It definitely wasn't right.

Please use this one instead.
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2018-09-16 17:22:31 UTC 
Committed to my repo pending the next release.
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2018-09-16 17:53:52 UTC 
Committed to 2.18.4.  Thanks!