Bug 229336 - www/nginx: STREAM_SSL_PREREAD has no effect
Summary: www/nginx: STREAM_SSL_PREREAD has no effect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-25 14:18 UTC by Dani
Modified: 2018-09-30 14:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani 2018-06-25 14:18:03 UTC
STREAM_SSL_PREREAD is default = on but has no effect. The configure option "--with-stream_ssl_preread_module" is not beeing added to the configure command and is then missing when trying to use: 
nginx: [emerg] unknown directive "ssl_preread" in /usr/local/etc/nginx/nginx.conf:150

Something like this would fix it:
-STREAM_SSL_PREREAD_OFF=                --without-stream_ssl_preread_module
+STREAM_SSL_PREREAD_CONFIGURE_ON=       --with-stream_ssl_preread_module
Comment 1 commit-hook freebsd_committer 2018-06-28 17:28:13 UTC
A commit references this bug:

Author: joneum
Date: Thu Jun 28 17:27:29 UTC 2018
New revision: 473502
URL: https://svnweb.freebsd.org/changeset/ports/473502

Log:
  - Update brotli to e26248e
  - Fix STREAM_SSL_PREREAD

  PR:		229336, 229237

Changes:
  head/www/nginx/Makefile
  head/www/nginx/Makefile.extmod
  head/www/nginx/distinfo
Comment 2 Jochen Neumeister freebsd_committer 2018-06-28 17:33:40 UTC
Landed. Thanks :-)
Comment 3 Peter Kubica 2018-09-30 14:47:56 UTC
Great work!
Could you please do the same for nginx-devel port?