Bug 229895 - databases/liquibase: Update to version 3.6.2
Summary: databases/liquibase: Update to version 3.6.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jochen Neumeister
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-07-19 23:09 UTC by Nathan
Modified: 2018-07-28 20:04 UTC (History)
2 users (show)

See Also:


Attachments
Update Patch (994 bytes, patch)
2018-07-19 23:09 UTC, Nathan
no flags Details | Diff
Update (994 bytes, patch)
2018-07-28 19:31 UTC, Nathan
no flags Details | Diff
patch (2.32 KB, patch)
2018-07-28 19:52 UTC, Jochen Neumeister
ndowens04: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-07-19 23:09:52 UTC
Created attachment 195284 [details]
Update Patch

Builds fine on 10.4-R and 11.2-S
Changelog: https://github.com/liquibase/liquibase/blob/master/changelog.txt
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-28 19:09:03 UTC
hm, are you sure, your patch is ok?

=======================<phase: patch          >============================
===>  Patching for liquibase-3.6.2
===>  Applying FreeBSD patches for liquibase-3.6.2
1 out of 1 hunks failed--saving rejects to liquibase.rej
=> FreeBSD patch patch-liquibase failed to apply cleanly.
*** Error code 1

Stop.
make: stopped in /usr/ports/databases/liquibase

http://joneumbox.org/data/11-1-i386-ports/2018-07-28_21h06m45s/logs/errors/liquibase-3.6.2.log
http://joneumbox.org/data/11-1-AMD64-ports/2018-07-28_21h06m41s/logs/errors/liquibase-3.6.2.log
Comment 2 Nathan 2018-07-28 19:15:54 UTC
(In reply to Jochen Neumeister from comment #1)
> hm, are you sure, your patch is ok?
> 
> =======================<phase: patch          >============================
> ===>  Patching for liquibase-3.6.2
> ===>  Applying FreeBSD patches for liquibase-3.6.2
> 1 out of 1 hunks failed--saving rejects to liquibase.rej
> => FreeBSD patch patch-liquibase failed to apply cleanly.
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/ports/databases/liquibase
> 
> http://joneumbox.org/data/11-1-i386-ports/2018-07-28_21h06m45s/logs/errors/
> liquibase-3.6.2.log
> http://joneumbox.org/data/11-1-AMD64-ports/2018-07-28_21h06m41s/logs/errors/
> liquibase-3.6.2.log

Revan# patch -p0 < /home/ndowens/liquibase.diff 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: databases/liquibase/Makefile
|===================================================================
|--- databases/liquibase/Makefile	(revision 474855)
|+++ databases/liquibase/Makefile	(working copy)
--------------------------
Patching file databases/liquibase/Makefile using Plan A...
Hunk #1 succeeded at 2 with fuzz 1.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: databases/liquibase/distinfo
|===================================================================
|--- databases/liquibase/distinfo	(revision 474855)
|+++ databases/liquibase/distinfo	(working copy)
--------------------------
Patching file databases/liquibase/distinfo using Plan A...
Hunk #1 succeeded at 1.
done
Revan#
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-28 19:24:48 UTC
This patch doesn't work, see the poudriere logs.
Comment 4 Nathan 2018-07-28 19:31:08 UTC
Created attachment 195553 [details]
Update

Sorry about that, not sure what happened, but this one is working for me now
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-28 19:51:08 UTC
(In reply to Nathan from comment #4)

this patch does't work, too.

See the log: 

=======================<phase: patch-depends  >============================
===========================================================================
=======================<phase: patch          >============================
===>  Patching for liquibase-3.6.2
===>  Applying FreeBSD patches for liquibase-3.6.2
1 out of 1 hunks failed--saving rejects to liquibase.rej
=> FreeBSD patch patch-liquibase failed to apply cleanly.
*** Error code 1

Stop.


You have a problem with files/patch-liquibase

I have a new patch here. Please test it :-)
Comment 7 Nathan 2018-07-28 19:54:45 UTC
(In reply to Jochen Neumeister from comment #5)
> (In reply to Nathan from comment #4)
> 
> this patch does't work, too.
> 
> See the log: 
> 
> =======================<phase: patch-depends  >============================
> ===========================================================================
> =======================<phase: patch          >============================
> ===>  Patching for liquibase-3.6.2
> ===>  Applying FreeBSD patches for liquibase-3.6.2
> 1 out of 1 hunks failed--saving rejects to liquibase.rej
> => FreeBSD patch patch-liquibase failed to apply cleanly.
> *** Error code 1
> 
> Stop.
> 
> 
> You have a problem with files/patch-liquibase
> 
> I have a new patch here. Please test it :-)

I think I figured out what was going on, svn up restores that patch and it's not needed. Though I believed I removed it before doing svn diff again
Comment 8 Jochen Neumeister freebsd_committer freebsd_triage 2018-07-28 20:04:01 UTC
Landed. Thanks :-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-07-28 20:04:24 UTC
A commit references this bug:

Author: joneum
Date: Sat Jul 28 20:03:52 UTC 2018
New revision: 475607
URL: https://svnweb.freebsd.org/changeset/ports/475607

Log:
  databases/liquibase: Update to version 3.6.2

  Changelog: https://github.com/liquibase/liquibase/blob/master/changelog.txt

  PR:		229895
  Submitted by:	Nathan <ndowens.fbsd@yandex.com> (maintainer)

Changes:
  head/databases/liquibase/Makefile
  head/databases/liquibase/distinfo
  head/databases/liquibase/files/patch-liquibase