Bug 229902 - graphics/diff-pdf: fix wx version
Summary: graphics/diff-pdf: fix wx version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-07-20 10:30 UTC by Zsolt Udvari
Modified: 2018-07-20 13:04 UTC (History)
1 user (show)

See Also:

Attachments
Patch (509 bytes, patch)
2018-07-20 10:30 UTC, Zsolt Udvari 		uzsolt: maintainer-approval+
Details | Diff
diff-pdf.diff (506 bytes, patch)
2018-07-20 10:47 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (uzsolt)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2018-07-20 10:30:44 UTC 
Created attachment 195299 [details]
Patch

My report was version 0.2 but the commit was the head version (https://svnweb.freebsd.org/ports?view=revision&revision=474820). In this version the port requires wx-3.0 (see http://beefy9.nyi.freebsd.org/data/111amd64-default/474922/logs/diff-pdf-0.2.27.log).
Poudriere passed (log: http://freebsd.uzsolt.hu/logs/graphics/diff-pdf/11amd64-head/diff-pdf-0.2.27.log).
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-07-20 10:47:41 UTC 
Created attachment 195300 [details]
diff-pdf.diff

3.0 isn't actually required and it builds and runs fine with 2.8 for me.
Ok if I commit this patch instead?
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2018-07-20 13:00:00 UTC 
(In reply to Tobias Kortkamp from comment #1)
If works well I think it's okay.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2018-07-20 13:03:43 UTC 
(In reply to Zsolt Udvari from comment #2)
Committed. Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-07-20 13:04:04 UTC 
A commit references this bug:

Author: tobik
Date: Fri Jul 20 13:03:25 UTC 2018
New revision: 475011
URL: https://svnweb.freebsd.org/changeset/ports/475011

Log:
  Unbreak graphics/diff-pdf

  wxWidgets 3.0 isn't actually required and it builds and runs fine with 2.8.
  Loosen the version requirement in configure.ac.

  PR:		229902
  Approved by:	Zsolt Udvari <uzsolt@uzsolt.hu> (maintainer)

Changes:
  head/graphics/diff-pdf/Makefile