Bug 230233 - print/html2ps: fix compatibility with perl 5.26
Summary: print/html2ps: fix compatibility with perl 5.26
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Hiroki Sato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-31 09:42 UTC by Sergey N. Voronkov
Modified: 2023-01-11 23:54 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (hrs)

Attachments
html2ps Cumulative patch (3.04 KB, patch)
2018-07-31 09:42 UTC, Sergey N. Voronkov 		no flags Details | Diff
patch (2.81 KB, patch)
2018-08-20 07:34 UTC, Sergey N. Voronkov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey N. Voronkov 2018-07-31 09:42:02 UTC 
Created attachment 195684 [details]
html2ps Cumulative patch

There are some incompatibilities with default perl version.

Fix is partially "stolen" from debian for "compatibility" reasons. (There is many other ways to fix tempnam() issue.)

Cumulative patch attached.
Comment 1 Sergey N. Voronkov 2018-08-03 06:12:34 UTC 
Just 4 lines of code to unbreak the port and so long to wait for maintainer approve?

Could please someone pick this up to commit.

Actual changes are:

1) POSIX::tmpnam() is market as unsafe. so let's use File::Temp.

+use File::Temp qw/ :POSIX /;

-$tmpname=$posix?POSIX::tmpnam():"h2p_$$";
+$tmpname=$posix?tmpnam():"h2p_$$";

2) Quote braces inside regexps:

-    if(/\/DH {/) {
+    if(/\/DH \{/) {

-    <HYPH>=~/\\patterns{.*/;
+    <HYPH>=~/\\patterns\{.*/;
Comment 2 Sergey N. Voronkov 2018-08-20 07:34:54 UTC 
Created attachment 196376 [details]
patch
Comment 3 Sergey N. Voronkov 2018-08-20 07:36:25 UTC 
Maintainer timeout. Please commit!

Change importance as "Affects Many People".

New "ready for commit" patch revision.
Comment 4 Sergey N. Voronkov 2018-09-10 05:30:23 UTC 
Nobody cares.
Comment 5 Hiroki Sato freebsd_committer freebsd_triage 2023-01-11 23:54:28 UTC 
Reopen