Bug 230264 - www/chromium: Add a script for automating the hanging tabs workaround
Summary: www/chromium: Add a script for automating the hanging tabs workaround
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: feature, patch
Depends on:
Blocks:
 
Reported: 2018-08-01 16:39 UTC by Mateusz Piotrowski
Modified: 2018-08-08 07:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)
0mp: maintainer-feedback? (0mp)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2018-08-01 16:39:57 UTC
At the moment //pkg-message// says that in order to work around the hanging tabs problem the user may wish to run the following commands:

```
# [ -d ~{user}/.cache/chromium ] || mkdir ~{user}/.cache/chromium
# echo "md $(echo ~{user})/.cache/chromium mfs rw,late,-w{user}:{group},-s300m 2 0" >> /etc/fstab
# mount ~{user}/.cache/chromium
```

This patch adds a fix-hanging-tabs.sh script to the `DATADIR`, which simplifies the process to just running

```
/usr/local/share/chromium/fix-hanging-tabs.sh $user $group
```

----

Differential revision with the patch: https://reviews.freebsd.org/D16544
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-08-05 12:19:34 UTC
(In reply to Mateusz Piotrowski from comment #0)

Good work! I'll include it with chromium update to 68.

Thanks
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-08-05 20:23:06 UTC
(In reply to Carlos J. Puga Medina from comment #1)

Cool. I'll wait for your commit then :) Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-08-07 13:57:11 UTC
A commit references this bug:

Author: cpm
Date: Tue Aug  7 13:56:33 UTC 2018
New revision: 476599
URL: https://svnweb.freebsd.org/changeset/ports/476599

Log:
  www/chromium: Update to 68.0.3440.84

  Changelog: https://chromium.googlesource.com/chromium/src/+log/67.0.3396.87..68.0.3440.84?pretty=fuller&n=10000

  At the moment pkg-message says that in order to work around the hanging tabs problem the user may wish to run the following commands:

  # [ -d ~{user}/.cache/chromium ] || mkdir ~{user}/.cache/chromium
  # echo "md $(echo ~{user})/.cache/chromium mfs rw,late,-w{user}:{group},-s300m 2 0" >> /etc/fstab
  # mount ~{user}/.cache/chromium

  Add fix-hanging-tabs.sh script to the DATADIR [1], which simplifies the process to just running

  /usr/local/share/chromium/fix-hanging-tabs.sh $user $group

  PR:		230264 [1]
  Submitted by:	0mp [1]
  MFH:		2018Q3
  Security:	http://vuxml.freebsd.org/freebsd/b9c525d9-9198-11e8-beba-080027ef1a23.html

Changes:
  head/www/chromium/Makefile
  head/www/chromium/distinfo
  head/www/chromium/files/audio_manager_openbsd.cc
  head/www/chromium/files/extra-patch-llvm-base
  head/www/chromium/files/extra-patch-llvm-port
  head/www/chromium/files/fix-hanging-tabs.sh
  head/www/chromium/files/patch-base__trace_event__process_memory_dump.h
  head/www/chromium/files/patch-base_debug_elf_reader_linux.cc
  head/www/chromium/files/patch-base_process_process__metrics__freebsd.cc
  head/www/chromium/files/patch-base_process_process__metrics__posix.cc
  head/www/chromium/files/patch-base_trace__event_process__memory__dump.cc
  head/www/chromium/files/patch-base_trace__event_process__memory__dump.h
  head/www/chromium/files/patch-build_config_BUILD.gn
  head/www/chromium/files/patch-build_config_BUILDCONFIG.gn
  head/www/chromium/files/patch-build_config_compiler_BUILD.gn
  head/www/chromium/files/patch-build_config_compiler_compiler.gni
  head/www/chromium/files/patch-chrome_browser_about__flags.cc
  head/www/chromium/files/patch-chrome_browser_chrome__content__browser__client.cc
  head/www/chromium/files/patch-chrome_browser_memory__details.cc
  head/www/chromium/files/patch-chrome_browser_tracing_crash__service__uploader.cc
  head/www/chromium/files/patch-chrome_browser_ui_views_accelerator__table.cc
  head/www/chromium/files/patch-chrome_browser_ui_views_frame_opaque__browser__frame__view__layout.cc
  head/www/chromium/files/patch-chrome_browser_ui_webui_extensions_extension__loader__handler.cc
  head/www/chromium/files/patch-chrome_common_chrome__features.cc
  head/www/chromium/files/patch-chrome_common_chrome__features.h
  head/www/chromium/files/patch-components_autofill_content_renderer_password__form__conversion__utils.cc
  head/www/chromium/files/patch-components_autofill_strings.grdp
  head/www/chromium/files/patch-components_crash_content_app_crashpad.cc
  head/www/chromium/files/patch-components_crash_core_common_BUILD.gn
  head/www/chromium/files/patch-components_services_filesystem_file_system_app.cc
  head/www/chromium/files/patch-content_app_content__main__runner.cc
  head/www/chromium/files/patch-content_app_content_main_runner_impl.cc
  head/www/chromium/files/patch-content_browser_BUILD.gn
  head/www/chromium/files/patch-content_browser_background_fetch_background_fetch_context.cc
  head/www/chromium/files/patch-content_browser_browser__main__loop.cc
  head/www/chromium/files/patch-content_browser_child__process__launcher__helper__linux.cc
  head/www/chromium/files/patch-content_browser_zygote_host_zygote_host_impl_linux.cc
  head/www/chromium/files/patch-content_browser_zygote_host_zygote_host_impl_linux.h
  head/www/chromium/files/patch-content_common_common_sandbox_support_linux.cc
  head/www/chromium/files/patch-content_public_browser_zygote_host_linux.h
  head/www/chromium/files/patch-content_public_common_zygote_features.gni
  head/www/chromium/files/patch-content_renderer_input_input_event_prediction.cc
  head/www/chromium/files/patch-content_renderer_render__thread__impl.cc
  head/www/chromium/files/patch-content_renderer_renderer_main.cc
  head/www/chromium/files/patch-media_ffmpeg_ffmpeg_common.h
  head/www/chromium/files/patch-media_filters_ffmpeg_demuxer.cc
  head/www/chromium/files/patch-media_filters_ffmpeg_demuxer_unittest.cc
  head/www/chromium/files/patch-net_base_address__tracker__linux.cc
  head/www/chromium/files/patch-net_quic_platform_impl_quic__ip__address__impl.cc
  head/www/chromium/files/patch-net_third_party_quic_platform_impl_quic_ip_address_impl.cc
  head/www/chromium/files/patch-pdf_pdfium_pdfium__engine.cc
  head/www/chromium/files/patch-sandbox_linux_BUILD.gn
  head/www/chromium/files/patch-sandbox_linux_services_init_process_reaper.cc
  head/www/chromium/files/patch-services_network_BUILD.gn
  head/www/chromium/files/patch-services_resource_coordinator_public_cpp_memory_instrumentation_os_metrics_linux.cc
  head/www/chromium/files/patch-services_service__manager_zygote_common_zygote_features.gni
  head/www/chromium/files/patch-services_service__manager_zygote_host_zygote_host_impl_linux.cc
  head/www/chromium/files/patch-services_service__manager_zygote_host_zygote_host_impl_linux.h
  head/www/chromium/files/patch-services_service__manager_zygote_zygote_host_linux.h
  head/www/chromium/files/patch-services_service__manager_zygote_zygote_linux.cc
  head/www/chromium/files/patch-services_service__manager_zygote_zygote_main_linux.cc
  head/www/chromium/files/patch-third__party_angle_BUILD.gn
  head/www/chromium/files/patch-third_party_crashpad_crashpad_util_misc_capture_context.h
  head/www/chromium/files/patch-third_party_perfetto_include_perfetto_base_build_config.h
  head/www/chromium/files/patch-third_party_perfetto_include_perfetto_base_watchdog_posix.h
  head/www/chromium/files/patch-third_party_perfetto_src_base_unix_task_runner.cc
  head/www/chromium/files/patch-third_party_perfetto_src_tracing_core_service_impl.cc
  head/www/chromium/files/patch-ui_gfx_BUILD.gn
  head/www/chromium/files/patch-ui_gl_BUILD.gn
  head/www/chromium/files/patch-ui_gl_gl_fence.cc
  head/www/chromium/files/patch-ui_gl_gl_implementation.cc
  head/www/chromium/files/patch-v8_BUILD.gn
  head/www/chromium/files/patch-v8_src_globals.h
  head/www/chromium/files/patch-v8_src_trap-handler_handler-inside.cc
  head/www/chromium/files/sndio_input.cc
  head/www/chromium/files/sndio_input.h
  head/www/chromium/files/sndio_output.cc
  head/www/chromium/pkg-message
  head/www/chromium/pkg-plist
Comment 4 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-08-07 13:58:48 UTC
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-08-08 07:09:22 UTC
A commit references this bug:

Author: cpm
Date: Wed Aug  8 07:08:47 UTC 2018
New revision: 476627
URL: https://svnweb.freebsd.org/changeset/ports/476627

Log:
  MFH: r476599

  www/chromium: Update to 68.0.3440.84

  Changelog: https://chromium.googlesource.com/chromium/src/+log/67.0.3396.87..68.0.3440.84?pretty=fuller&n=10000

  At the moment pkg-message says that in order to work around the hanging tabs problem the user may wish to run the following commands:

  # [ -d ~{user}/.cache/chromium ] || mkdir ~{user}/.cache/chromium
  # echo "md $(echo ~{user})/.cache/chromium mfs rw,late,-w{user}:{group},-s300m 2 0" >> /etc/fstab
  # mount ~{user}/.cache/chromium

  Add fix-hanging-tabs.sh script to the DATADIR [1], which simplifies the process to just running

  /usr/local/share/chromium/fix-hanging-tabs.sh $user $group

  PR:		230264 [1]
  Submitted by:	0mp [1]
  Security:	http://vuxml.freebsd.org/freebsd/b9c525d9-9198-11e8-beba-080027ef1a23.html

  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/www/chromium/Makefile
  branches/2018Q3/www/chromium/distinfo
  branches/2018Q3/www/chromium/files/audio_manager_openbsd.cc
  branches/2018Q3/www/chromium/files/extra-patch-llvm-base
  branches/2018Q3/www/chromium/files/extra-patch-llvm-port
  branches/2018Q3/www/chromium/files/fix-hanging-tabs.sh
  branches/2018Q3/www/chromium/files/patch-base__trace_event__process_memory_dump.h
  branches/2018Q3/www/chromium/files/patch-base_debug_elf_reader_linux.cc
  branches/2018Q3/www/chromium/files/patch-base_process_process__metrics__freebsd.cc
  branches/2018Q3/www/chromium/files/patch-base_process_process__metrics__posix.cc
  branches/2018Q3/www/chromium/files/patch-base_trace__event_process__memory__dump.cc
  branches/2018Q3/www/chromium/files/patch-base_trace__event_process__memory__dump.h
  branches/2018Q3/www/chromium/files/patch-build_config_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-build_config_BUILDCONFIG.gn
  branches/2018Q3/www/chromium/files/patch-build_config_compiler_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-build_config_compiler_compiler.gni
  branches/2018Q3/www/chromium/files/patch-chrome_browser_about__flags.cc
  branches/2018Q3/www/chromium/files/patch-chrome_browser_chrome__content__browser__client.cc
  branches/2018Q3/www/chromium/files/patch-chrome_browser_memory__details.cc
  branches/2018Q3/www/chromium/files/patch-chrome_browser_tracing_crash__service__uploader.cc
  branches/2018Q3/www/chromium/files/patch-chrome_browser_ui_views_accelerator__table.cc
  branches/2018Q3/www/chromium/files/patch-chrome_browser_ui_views_frame_opaque__browser__frame__view__layout.cc
  branches/2018Q3/www/chromium/files/patch-chrome_browser_ui_webui_extensions_extension__loader__handler.cc
  branches/2018Q3/www/chromium/files/patch-chrome_common_chrome__features.cc
  branches/2018Q3/www/chromium/files/patch-chrome_common_chrome__features.h
  branches/2018Q3/www/chromium/files/patch-components_autofill_content_renderer_password__form__conversion__utils.cc
  branches/2018Q3/www/chromium/files/patch-components_autofill_strings.grdp
  branches/2018Q3/www/chromium/files/patch-components_crash_content_app_crashpad.cc
  branches/2018Q3/www/chromium/files/patch-components_crash_core_common_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-components_services_filesystem_file_system_app.cc
  branches/2018Q3/www/chromium/files/patch-content_app_content__main__runner.cc
  branches/2018Q3/www/chromium/files/patch-content_app_content_main_runner_impl.cc
  branches/2018Q3/www/chromium/files/patch-content_browser_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-content_browser_background_fetch_background_fetch_context.cc
  branches/2018Q3/www/chromium/files/patch-content_browser_browser__main__loop.cc
  branches/2018Q3/www/chromium/files/patch-content_browser_child__process__launcher__helper__linux.cc
  branches/2018Q3/www/chromium/files/patch-content_browser_zygote_host_zygote_host_impl_linux.cc
  branches/2018Q3/www/chromium/files/patch-content_browser_zygote_host_zygote_host_impl_linux.h
  branches/2018Q3/www/chromium/files/patch-content_common_common_sandbox_support_linux.cc
  branches/2018Q3/www/chromium/files/patch-content_public_browser_zygote_host_linux.h
  branches/2018Q3/www/chromium/files/patch-content_public_common_zygote_features.gni
  branches/2018Q3/www/chromium/files/patch-content_renderer_input_input_event_prediction.cc
  branches/2018Q3/www/chromium/files/patch-content_renderer_render__thread__impl.cc
  branches/2018Q3/www/chromium/files/patch-content_renderer_renderer_main.cc
  branches/2018Q3/www/chromium/files/patch-media_ffmpeg_ffmpeg_common.h
  branches/2018Q3/www/chromium/files/patch-media_filters_ffmpeg_demuxer.cc
  branches/2018Q3/www/chromium/files/patch-media_filters_ffmpeg_demuxer_unittest.cc
  branches/2018Q3/www/chromium/files/patch-net_base_address__tracker__linux.cc
  branches/2018Q3/www/chromium/files/patch-net_quic_platform_impl_quic__ip__address__impl.cc
  branches/2018Q3/www/chromium/files/patch-net_third_party_quic_platform_impl_quic_ip_address_impl.cc
  branches/2018Q3/www/chromium/files/patch-pdf_pdfium_pdfium__engine.cc
  branches/2018Q3/www/chromium/files/patch-sandbox_linux_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-sandbox_linux_services_init_process_reaper.cc
  branches/2018Q3/www/chromium/files/patch-services_network_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-services_resource_coordinator_public_cpp_memory_instrumentation_os_metrics_linux.cc
  branches/2018Q3/www/chromium/files/patch-services_service__manager_zygote_common_zygote_features.gni
  branches/2018Q3/www/chromium/files/patch-services_service__manager_zygote_host_zygote_host_impl_linux.cc
  branches/2018Q3/www/chromium/files/patch-services_service__manager_zygote_host_zygote_host_impl_linux.h
  branches/2018Q3/www/chromium/files/patch-services_service__manager_zygote_zygote_host_linux.h
  branches/2018Q3/www/chromium/files/patch-services_service__manager_zygote_zygote_linux.cc
  branches/2018Q3/www/chromium/files/patch-services_service__manager_zygote_zygote_main_linux.cc
  branches/2018Q3/www/chromium/files/patch-third__party_angle_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-third_party_crashpad_crashpad_util_misc_capture_context.h
  branches/2018Q3/www/chromium/files/patch-third_party_perfetto_include_perfetto_base_build_config.h
  branches/2018Q3/www/chromium/files/patch-third_party_perfetto_include_perfetto_base_watchdog_posix.h
  branches/2018Q3/www/chromium/files/patch-third_party_perfetto_src_base_unix_task_runner.cc
  branches/2018Q3/www/chromium/files/patch-third_party_perfetto_src_tracing_core_service_impl.cc
  branches/2018Q3/www/chromium/files/patch-ui_gfx_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-ui_gl_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-ui_gl_gl_fence.cc
  branches/2018Q3/www/chromium/files/patch-ui_gl_gl_implementation.cc
  branches/2018Q3/www/chromium/files/patch-v8_BUILD.gn
  branches/2018Q3/www/chromium/files/patch-v8_src_globals.h
  branches/2018Q3/www/chromium/files/patch-v8_src_trap-handler_handler-inside.cc
  branches/2018Q3/www/chromium/files/sndio_input.cc
  branches/2018Q3/www/chromium/files/sndio_input.h
  branches/2018Q3/www/chromium/files/sndio_output.cc
  branches/2018Q3/www/chromium/pkg-message
  branches/2018Q3/www/chromium/pkg-plist