Created attachment 195872 [details] Update Changelog: https://github.com/xonsh/xonsh/blob/master/CHANGELOG.rst Portlint AC: ok
Created attachment 195873 [details] Poudriere Log 11.2-Stable
Created attachment 195874 [details] Poudriere Log 10.4-Release
Created attachment 196112 [details] Update
Created attachment 196264 [details] Upgrade shells/xonsh: Update to 0.7.5 Changelog: https://github.com/xonsh/xonsh/blob/0.7.5/CHANGELOG.rst
The port works fine in the new version.
Created attachment 196493 [details] [patch] shells/xonsh-0.7.6
Comment on attachment 196493 [details] [patch] shells/xonsh-0.7.6 Update patch to match version 0.7.6
Created attachment 196703 [details] Update to version 0.7.7 Updating the patch to version 0.7.7
Created attachment 197066 [details] Upgrade to 0.7.8 Upgrade of the port to version 0.7.8
(In reply to Roberto Fernandez Cueto from comment #9) Why did you take out LICENSE= ....
(In reply to Nathan from comment #10) I suspect LICENSE was removed because of the following error: ===> Missing license file for BSD2CLAUSE in /license *** Error code 1 That's because the LICENSE_FILE line that was added in the patch is: LICENSE_FILE= ${WRCDIR}/license Two problems with that: - WRCDIR typo instead of WRKDIR - WRKDIR would be wrong, too. WRKSRC is correct. Removing LICENSE just skips all the license support, so it seems to "fix" the problem, but effectively just comments it out. In short, the patch should be updated to leave LICENSE as is and add this line: LICENSE_FILE= ${WRKSRC}/license
(In reply to John Hein from comment #11) License= should be in Makefile either way. License_file should be provided IF it’s in the source file, if it isn’t just providing a known license type works without error So in short LICENSE needs to stay in Makefile. When I did previous version I had no error from it
Reason there is an error is because WRKSRC is spelled wrong when I relooked at patch
(In reply to John Hein from comment #11) Misread your comment a bit, wish I could delete mine lol but yes you’re right. Since it’s misspelled Makefile overlooks it
There is a revision for this issue in phabricator: https://reviews.freebsd.org/D17152
(In reply to Roberto Fernandez Cueto from comment #15) Roberto, if you're happy with the patch, indicate that with the maintainer approval flag. This will give the committer the hint that it's ready to be committed from the maintainer's point of view.
Created attachment 197074 [details] Upgrade to 0.7.8 Fixing the patch using directions from 0mp@
I'm on it. I'll commit it in a couple minutes.
A commit references this bug: Author: 0mp Date: Sat Sep 15 12:34:48 UTC 2018 New revision: 479833 URL: https://svnweb.freebsd.org/changeset/ports/479833 Log: shells/xonsh: Upgrade to version 0.7.8 Changelog: https://github.com/xonsh/xonsh/blob/0.7.8/CHANGELOG.rst PR: 230369 Submitted by: Roberto Fernandez Cueto <roberfern@gmail.com> (maintainer) Reported by: Nathan <ndowens@yahoo.com> Reviewed by: krion, mat Reviewed by: Nathan <ndowens@yahoo.com> (previous version) Reviewed by: John Hein <z7dr6ut7gs@snkmail.com> (previous version) Approved by: krion (mentor) Differential Revision: https://reviews.freebsd.org/D17152 Changes: head/shells/xonsh/Makefile head/shells/xonsh/distinfo head/shells/xonsh/files/patch-xonsh_platform.py head/shells/xonsh/files/patch-xonsh_xoreutils_uptime.py
Big thanks to all of you for your contribution to this PR!