Bug 230371 - stage-qa doesn't complain about unstripped shared libs when they don't have .debug_info sections
Summary: stage-qa doesn't complain about unstripped shared libs when they don't have ....
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-05 05:12 UTC by Yuri Victorovich
Modified: 2018-08-05 18:47 UTC (History)
1 user (show)

See Also:

Attachments
patch adding 2 more section types to the check (756 bytes, patch)
2018-08-05 07:41 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2018-08-05 05:12:52 UTC 
For example, math/triangle. Please remove the STRIP_CMD command and observe that stage-qa doesn't complain.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-05 07:40:18 UTC 
stage-qa only looks at .debug_info sections, while the presence of .symtab and .strtab sections is also considered to make ELF unstripped.

Attaching as patch.

It's possible that there are some other sections that make ELF unstripped. I couldn't find documentation about this.

And alternative approach is to use file(1). When file(1) says 'not stripped', this is when ELF isn't stripped.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-05 07:41:29 UTC 
Created attachment 195891 [details]
patch adding 2 more section types to the check
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-05 07:42:25 UTC 
Personally, I would prefer to go with what file(1) says about ELF being stripped.
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2018-08-05 18:47:20 UTC 
This goes against what ports r469589 did.