Bug 230523 - deskutils/fet: update to 5.37.1
Summary: deskutils/fet: update to 5.37.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-08-11 10:48 UTC by Zsolt Udvari
Modified: 2018-08-27 08:59 UTC (History)
3 users (show)

See Also:
uzsolt: maintainer-feedback+

Attachments
patch (1.65 KB, patch)
2018-08-11 10:48 UTC, Zsolt Udvari 		uzsolt: maintainer-approval+
Details | Diff
patch with c++14 (1.68 KB, patch)
2018-08-23 06:44 UTC, Zsolt Udvari 		uzsolt: maintainer-approval+
Details | Diff
deskutils__fet.diff (598 bytes, patch)
2018-08-27 08:16 UTC, Tobias Kortkamp 		uzsolt: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2018-08-11 10:48:27 UTC 
Created attachment 196074 [details]
patch

Simple update to 5.37.1

- remove qt:4 from USES
- fix QT5_USE
- use OPTION_VARS instead of testing

Fet changelog (https://lalescu.ro/liviu/fet/news.html):
- code update: speed of generation is improved by 5%-25%
- some bugs fixed
- code cleanup
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2018-08-18 08:42:05 UTC 
This does not build on 10.4:

...
engine/timetableexport.cpp:5175:29: error: use of undeclared identifier 'qAsConst' for(const QString& atn : qAsConst(act->activityTagsNames)){
...
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2018-08-23 06:44:42 UTC 
Created attachment 196466 [details]
patch with c++14

Added c++14 requirement to build properly on 10.4.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2018-08-23 06:45:54 UTC 
(In reply to Thomas Zander from comment #1)
Now builds on 10.4 too. Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-08-25 09:37:01 UTC 
A commit references this bug:

Author: riggs
Date: Sat Aug 25 09:36:44 UTC 2018
New revision: 478018
URL: https://svnweb.freebsd.org/changeset/ports/478018

Log:
  Update to upstream version 5.37.1

  PR:		230523
  Submitted by:	uzsolt@uzsolt.hu (maintainer)

Changes:
  head/deskutils/fet/Makefile
  head/deskutils/fet/distinfo
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2018-08-25 09:42:12 UTC 
Thanks for fixing this! Committed!
Comment 6 Zsolt Udvari freebsd_committer freebsd_triage 2018-08-26 11:22:55 UTC 
I received an email about build failure on 11.1: http://beefy9.nyi.freebsd.org/data/111amd64-default/478090/logs/fet-5.37.1.log
On 11.2 builds well.

Should we fix it? 11.1's end of support is near (about one month).
Comment 7 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-27 08:16:56 UTC 
Created attachment 196588 [details]
deskutils__fet.diff

Yes, it should be fixed.  Support means that we need to make sure
it works until the very end.

Looks like fet actually uses C++14 but upstream does not properly
select it themselves, so we should add USE_CXXSTD=c++14 to the port
to fix the build.  Clang 6 defaults to it, so it's no surprise that
it works on 11.2.
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-27 08:17:23 UTC 
Reopen.
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-08-27 08:59:23 UTC 
A commit references this bug:

Author: tobik
Date: Mon Aug 27 08:58:39 UTC 2018
New revision: 478183
URL: https://svnweb.freebsd.org/changeset/ports/478183

Log:
  deskutils/fet: Fix build on 11.1

  In file included from engine/timetableexport.cpp:46:
  engine/timetable_defs.h:38:20: error: unknown type name 'constexpr'
  template <class T> constexpr std::add_const_t<T>& qAsConst(T& t) noexcept
                     ^

  http://beefy10.nyi.freebsd.org/data/111i386-default/478099/logs/fet-5.37.1.log

  PR:		230523
  Approved by:	maintainer

Changes:
  head/deskutils/fet/Makefile