Bug 230571 - src/sys/dev/e1000/if_em.c:796]: (style) Same expression on both sides of '|'
Summary: src/sys/dev/e1000/if_em.c:796]: (style) Same expression on both sides of '|'
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Marius Strobl
URL:
Keywords: IntelNetworking
Depends on:
Blocks:
 
Reported: 2018-08-12 20:24 UTC by David Binderman
Modified: 2018-08-13 21:02 UTC (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2018-08-12 20:24:05 UTC 
Source code is

                scctx->isc_tx_csum_flags = CSUM_TCP | CSUM_UDP | CSUM_TSO | CSUM_IP6_TCP \
                        | CSUM_IP6_UDP | CSUM_IP6_TCP;

Maybe better code

                scctx->isc_tx_csum_flags = CSUM_TCP | CSUM_UDP | CSUM_TSO | CSUM_IP6_TCP \
                        | CSUM_IP6_UDP | CSUM_IP6_TSO;
Comment 1 Mark Johnston freebsd_committer freebsd_triage 2018-08-13 15:11:47 UTC 
Sorry for the noise, just meant to cc marius@.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-13 20:29:47 UTC 
A commit references this bug:

Author: marius
Date: Mon Aug 13 20:29:40 UTC 2018
New revision: 337726
URL: https://svnweb.freebsd.org/changeset/base/337726

Log:
  Remove the duplicated CSUM_IP6_TCP introduced in r311849 from the TX
  checksum capabilities of IGB-class MACs. While at it, fix the line
  wrapping.

  PR:	230571

Changes:
  head/sys/dev/e1000/if_em.c