Bug 230674 - math/blitz++: fix build on FreeBSD 11.2
Summary: math/blitz++: fix build on FreeBSD 11.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-16 18:55 UTC by Ting-Wei Lan
Modified: 2018-08-25 10:23 UTC (History)
3 users (show)

See Also:


Attachments
Fix blitz++ build on FreeBSD 11.2 (711 bytes, patch)
2018-08-16 18:55 UTC, Ting-Wei Lan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2018-08-16 18:55:44 UTC
Created attachment 196257 [details]
Fix blitz++ build on FreeBSD 11.2

blitz++ currently fails to build on FreeBSD 11.2:

Making all in lib
gmake[2]: Entering directory '/wrkdirs/usr/ports/math/blitz++/work/blitz-0.9/lib'
if /bin/sh ../libtool --mode=compile --tag=CXX c++ -DHAVE_CONFIG_H   -I.. -I..    -MT globals.lo -MD -MP -MF ".deps/globals.Tpo" -c -o globals.lo `test -f '../src/globals.cpp' || echo './'`../src/globals.cpp; \
then mv -f ".deps/globals.Tpo" ".deps/globals.Plo"; else rm -f ".deps/globals.Tpo"; exit 1; fi
mkdir .libs
 c++ -DHAVE_CONFIG_H -I.. -I.. -MT globals.lo -MD -MP -MF .deps/globals.Tpo -c ../src/globals.cpp  -fPIC -DPIC -o .libs/globals.o
In file included from ../src/globals.cpp:11:
In file included from ../blitz/indexexpr.h:30:
In file included from ../blitz/tinyvec.h:30:
../blitz/blitz.h:58:12: fatal error: 'iostream.h' file not found
  #include <iostream.h>
           ^~~~~~~~~~~~
1 error generated.
gmake[2]: *** [Makefile:381: globals.lo] Error 1
gmake[2]: Leaving directory '/wrkdirs/usr/ports/math/blitz++/work/blitz-0.9/lib'
gmake[1]: *** [Makefile:377: all-recursive] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/math/blitz++/work/blitz-0.9'
*** Error code 1

Stop.
make: stopped in /usr/ports/math/blitz++

It seems that it is the configure script that is too old to work. To fix the problem, I add USES=autoreconf to the port Makefile. However, it seems that running autoreconf triggers the rebuild of documentation because of the existing patches, and I cannot find a way to build documentation without errors. I rename these two patches to prevent them from modifying .texi files when DOCS option is not enabled, so it will at least build successully when DOCS is disabled, which is the default.

Since svn doesn't seem to have a way to handle renamed files in a patch file, some manual steps are needed to apply the patch I uploaded here.

$ svn mv files/patch-doc-arrays-expr.texi files/extra-patch-doc-arrays-expr.texi
$ svn mv files/patch-doc-arrays-expr.texi files/extra-patch-doc-arrays-expr.texi
$ svn patch math_blitz++.patch
Comment 1 Nathan 2018-08-22 11:37:03 UTC
Iā€™m currently working on updating this port. Hopefully it will fix this
Comment 2 Nathan 2018-08-23 03:31:26 UTC
(In reply to Nathan from comment #1)

Update: Updating the port, so far so good; It's building fine in a 11.2 jail. Will submit it to bugs to have it updated as soon as I have it ready
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2018-08-25 10:09:18 UTC
Patch provided in bug #230833 fixes build in 11.2
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-08-25 10:16:37 UTC
A commit references this bug:

Author: riggs
Date: Sat Aug 25 10:16:17 UTC 2018
New revision: 478020
URL: https://svnweb.freebsd.org/changeset/ports/478020

Log:
  Update to upstream release 1.0.1, fix build on 11.2

  Detailed submitter log:
  - Update to 1.0.1
  - Switched to Github
    - Has newest sources
  - Updated WWW in pkg-desc
    - Current www doesn't exist
  - Removed doc depends/build
    - Does not build/install
  - Removed doxygen dir
    - Not needed/used

  PR:		230833 [1], 230674 [2]
  Submitted by:	ndowens@yahoo.com [1]
  Reported by:	lantw44@gmail.com [2]
  MFH:		2018Q3

Changes:
  head/math/blitz++/Makefile
  head/math/blitz++/distinfo
  head/math/blitz++/files/
  head/math/blitz++/pkg-descr
  head/math/blitz++/pkg-plist
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-08-25 10:19:41 UTC
A commit references this bug:

Author: riggs
Date: Sat Aug 25 10:18:56 UTC 2018
New revision: 478021
URL: https://svnweb.freebsd.org/changeset/ports/478021

Log:
  MFH: r478020

  Update to upstream release 1.0.1, fix build on 11.2

  Detailed submitter log:
  - Update to 1.0.1
  - Switched to Github
    - Has newest sources
  - Updated WWW in pkg-desc
    - Current www doesn't exist
  - Removed doc depends/build
    - Does not build/install
  - Removed doxygen dir
    - Not needed/used

  PR:		230833 [1], 230674 [2]
  Submitted by:	ndowens@yahoo.com [1]
  Reported by:	lantw44@gmail.com [2]

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/math/blitz++/Makefile
  branches/2018Q3/math/blitz++/distinfo
  branches/2018Q3/math/blitz++/files/
  branches/2018Q3/math/blitz++/pkg-descr
  branches/2018Q3/math/blitz++/pkg-plist