Bug 230740 - net-mgmt/statsite: Add RC script
Summary: net-mgmt/statsite: Add RC script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-19 02:05 UTC by Nathan
Modified: 2018-09-09 15:56 UTC (History)
1 user (show)

See Also:

Attachments
Added RC script (1.63 KB, patch)
2018-08-19 02:05 UTC, Nathan 		no flags Details | Diff
Add RC script (1.63 KB, patch)
2018-09-02 04:57 UTC, Nathan 		no flags Details | Diff
Add RC script (1.60 KB, patch)
2018-09-04 12:57 UTC, Nathan 		no flags Details | Diff
Add RC script (1.54 KB, patch)
2018-09-04 14:06 UTC, Nathan 		no flags Details | Diff
Add RC script (852 bytes, patch)
2018-09-04 17:11 UTC, Nathan 		no flags Details | Diff
Add RC script (973 bytes, patch)
2018-09-04 17:13 UTC, Nathan 		no flags Details | Diff
ADD RC (1.96 KB, patch)
2018-09-08 17:03 UTC, Nathan 		no flags Details | Diff
Add RC (2.12 KB, patch)
2018-09-08 18:29 UTC, Nathan 		ndowens04: maintainer-approval?
Details | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-08-19 02:05:54 UTC 
Created attachment 196333 [details]
Added RC script

Added RC script
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2018-08-19 02:05:54 UTC 
Maintainer informed via mail
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-22 06:26:34 UTC 
Comment on attachment 196333 [details]
Added RC script

+#				Set it to YES to enable doormand.

Should probably be changed to statsite ;)

+command_args="-u statsd -P ${pidfile} /usr/local/bin/statsite"

%%PREFIX/bin/statsite

+: ${statsite_config="%%PREFIX%%/etc/statsite.conf"}

This is never used anywhere.
Comment 3 Nathan 2018-09-02 04:57:28 UTC 
Created attachment 196779 [details]
Add RC script
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-04 12:25:30 UTC 
Comment on attachment 196779 [details]
Add RC script

It's identical to the first patch version.
Comment 5 Nathan 2018-09-04 12:57:54 UTC 
Created attachment 196854 [details]
Add RC script
Comment 6 Nathan 2018-09-04 12:58:56 UTC 
Tried requesting approval from maintainer, but seems doesn't have bugzilla account
Comment 7 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-04 13:03:16 UTC 
Comment on attachment 196854 [details]
Add RC script

statsite_config still doesn't do anything.
Comment 8 Nathan 2018-09-04 14:06:59 UTC 
Created attachment 196857 [details]
Add RC script
Comment 9 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-04 14:29:27 UTC 
Comment on attachment 196857 [details]
Add RC script

Why did you remove statsite_config?  Why not pass it to statsite
command_args via -f ?

/usr/local/bin/statsite should be %%PREFIX%%/bin/statsite
Comment 10 Nathan 2018-09-04 15:35:13 UTC 
(In reply to Tobias Kortkamp from comment #9)
With it, it doesn't start, and seems even if i edit the conf file doesn't change ports when it starts. Seems it could be the conf file it's self; Haven't figured out what yet though, or possibly statsite itself having -f option issue
Comment 11 Nathan 2018-09-04 17:11:26 UTC 
Created attachment 196861 [details]
Add RC script
Comment 12 Nathan 2018-09-04 17:13:19 UTC 
Created attachment 196862 [details]
Add RC script

Added revision, as needed to correct python cmd in conf sample and remove two lines that kept onestart/onestop from working

Seems to be working properly for me
Comment 13 Tobias Kortkamp freebsd_committer freebsd_triage 2018-09-07 12:55:05 UTC 
Comment on attachment 196862 [details]
Add RC script

Patch is missing the rc script now.
Comment 14 Nathan 2018-09-08 17:03:53 UTC 
Created attachment 196966 [details]
ADD RC
Comment 15 Nathan 2018-09-08 18:29:34 UTC 
Created attachment 196967 [details]
Add RC
Comment 16 commit-hook freebsd_committer freebsd_triage 2018-09-09 15:56:41 UTC 
A commit references this bug:

Author: tobik
Date: Sun Sep  9 15:56:19 UTC 2018
New revision: 479292
URL: https://svnweb.freebsd.org/changeset/ports/479292

Log:
  net-mgmt/statsite: Add rc script

  PR:		230740
  Submitted by:	ndowens@yahoo.com
  Approved by:	rbarabas@rbarabas.info (maintainer timeout, 3 weeks)

Changes:
  head/net-mgmt/statsite/Makefile
  head/net-mgmt/statsite/files/
  head/net-mgmt/statsite/files/statsite.in