Bug 230882 - comms/telldus-core: Fix build with Clang 6
Summary: comms/telldus-core: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-25 04:08 UTC by Tobias Kortkamp
Modified: 2018-08-27 16:10 UTC (History)
1 user (show)

See Also:
johan: maintainer-feedback+


Attachments
comms__telldus-core.diff (476 bytes, patch)
2018-08-25 04:09 UTC, Tobias Kortkamp
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2018-08-25 04:08:39 UTC
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer 2018-08-25 04:09:01 UTC
Created attachment 196519 [details]
comms__telldus-core.diff
Comment 2 Johan Ström 2018-08-27 05:22:15 UTC
Thanks for checking this out, I've seen the alert mails but have not had time to look into it.

I have no objections, if that works (and is backwards compatible) then I guess it's good :)
Comment 3 Tobias Kortkamp freebsd_committer 2018-08-27 05:31:27 UTC
(In reply to Johan Ström from comment #2)
Thank you.  It will do for now to make it work like before, but you should
definitely report this to upstream if you get a chance.
Comment 4 commit-hook freebsd_committer 2018-08-27 05:31:46 UTC
A commit references this bug:

Author: tobik
Date: Mon Aug 27 05:31:21 UTC 2018
New revision: 478176
URL: https://svnweb.freebsd.org/changeset/ports/478176

Log:
  comms/telldus-core: Fix build with Clang 6

  common/EventHandler_unix.cpp:83:24: error: non-constant-expression cannot be narrowed from type 'unsigned long long' to 'time_t' (aka 'int') in initializer list [-Wc++11-narrowing]
                  timespec abstime = { now.tv_sec + (abstime_ns_large / 1000000000), abstime_ns_large % 1000000000 };
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/telldus-core-2.1.2_5.log

  PR:		230882
  Submitted by:	tobik
  Approved by:	Johan Str?m <johan@stromnet.se> (maintainer)

Changes:
  head/comms/telldus-core/Makefile
Comment 5 Johan Ström 2018-08-27 16:10:46 UTC
Upstream is unfortunately more or less dead/unmaintained, so very small chance of fixing problems there (as evident by multitude of patches we already have in the port).