Bug 231152 - archivers/rpm4: fix multiple problems
Summary: archivers/rpm4: fix multiple problems
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-04 12:32 UTC by Dmitry Marakasov
Modified: 2018-09-04 13:40 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (rodrigo)


Attachments
Patch (16.13 KB, patch)
2018-09-04 12:32 UTC, Dmitry Marakasov
no flags Details | Diff
Updated patch (16.11 KB, patch)
2018-09-04 13:27 UTC, Rodrigo Osorio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2018-09-04 12:32:07 UTC
Created attachment 196853 [details]
Patch

The last update introduced several problems:
- plist broken for WITHOUT=NLS case
- plist broken for WITH=PLUGINS case
- incorrect shebangs in new scripts
- missing depends  for new scripts
Please test the port more thoroughly next time.

The attached patch:
- Fixes plist for mentioned cases, cleans it up, sorts and removes placeholders garbage
- Fixes new shebang problems
- Adds missing depends for new scripts
Comment 1 Rodrigo Osorio freebsd_committer 2018-09-04 13:27:46 UTC
Created attachment 196855 [details]
Updated patch
Comment 2 Rodrigo Osorio freebsd_committer 2018-09-04 13:28:51 UTC
Hi,

I fix some of the breakages you report before so I updated the patch.
Thanks for the heads up
Comment 3 commit-hook freebsd_committer 2018-09-04 13:35:19 UTC
A commit references this bug:

Author: rodrigo
Date: Tue Sep  4 13:35:10 UTC 2018
New revision: 478959
URL: https://svnweb.freebsd.org/changeset/ports/478959

Log:
  Fix remaining issues after update :

  - Fixes plist for mentioned cases, cleans it up, sorts and removes placeholders garbage
  - Fixes new shebang problems
  - Adds missing depends for new scripts
  - Bump PORTREVISION

  PR:		231152
  Submitted by:	amdmi3

Changes:
  head/archivers/rpm4/Makefile
  head/archivers/rpm4/pkg-plist