Bug 231310 - emulators/nestopia: add libretro build
Summary: emulators/nestopia: add libretro build
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-11 20:09 UTC by Loïc Bartoletti
Modified: 2020-04-02 06:47 UTC (History)
4 users (show)

See Also:

Attachments
nestopia libretro (937 bytes, patch)
2018-09-11 20:09 UTC, Loïc Bartoletti 		no flags Details | Diff
nestopia libretro as an option (1.55 KB, patch)
2019-10-27 13:24 UTC, Loïc Bartoletti 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer freebsd_triage 2018-09-11 20:09:43 UTC 
Created attachment 197031 [details]
nestopia libretro

I don't know if an option or a sub-package should be better. Anyway, here is the addition of the libretro support for nestopia. Thanks OpenBSD for the steps to build it.
Comment 1 Nathan 2018-09-12 22:23:16 UTC 
I would tend to lean more toward option instead of forced, but that's just me. When I do port related stuff I tend to give option, as I view it gives choice instead of forcing it onto someone
Comment 2 Nathan 2018-09-12 22:26:26 UTC 
So you could in this case do:
post-build-LIBRETRO-on:
        cd ${WRKSRC}/libretro && gmake
post-install-LIBRETRO-on:
        ${MKDIR} ${STAGEDIR}${PREFIX}/lib/libretro
	${INSTALL_DATA} ${WRKSRC}/libretro/nestopia_libretro.so \
		${STAGEDIR}${PREFIX}/lib/libretro
Comment 3 Nathan 2018-09-12 22:27:53 UTC 
Also if it only needs gmake for libretro
LIBRETRO_USES=     gmake

All this is if options is chosen way to go
Comment 4 Neel Chauhan freebsd_committer freebsd_triage 2018-09-15 01:36:05 UTC 
I am on the same boat as Nathan: an option instead of forced.

Why? some people may want libretro, others may want a stripped down system with only the essentials, we shouldn't force one configuration (unlike what's done with SystemD).
Comment 5 Loïc Bartoletti freebsd_committer freebsd_triage 2018-09-15 07:36:59 UTC 
I can agree with you, as mentioned, I don't know what is the better option :)
Maybe sub-packages as OpenBSD, but we don't have (yet) sub-packages.

Feel free to change it or I send you the modified version this week.

Regards.
Comment 6 Walter Schwarzenfeld 2019-09-02 10:42:50 UTC 
Any news here?
Comment 7 Loïc Bartoletti freebsd_committer freebsd_triage 2019-10-27 13:24:29 UTC 
Created attachment 208633 [details]
nestopia libretro as an option

Sorry for the delay...
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2020-03-20 08:58:06 UTC 
Superseded by https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244897