Bug 231331 - security/apache-xml-security-c: Not broken with OpenSSL 1.1.x
Summary: security/apache-xml-security-c: Not broken with OpenSSL 1.1.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-12 17:29 UTC by Bernard Spil
Modified: 2018-12-29 12:43 UTC (History)
2 users (show)

See Also:

Attachments
Prepare for LLD on i386 (2.88 KB, patch)
2018-09-14 01:20 UTC, Nathan 		no flags Details | Diff
Prepare for LLD on i386; Strip library file (2.96 KB, patch)
2018-09-14 01:25 UTC, Nathan 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2018-09-12 17:29:04 UTC 
The port builds OK for me with OpenSSL 1.1.0 as well as OpenSSL 1.1.1. Am I missing something?

https://keg.brnrd.eu/data/111amd64-default-openssl110/2018-08-17_12h10m13s/logs/apache-xml-security-c-2.0.1.log
https://keg.brnrd.eu/data/111amd64-default-openssl111/2018-08-14_10h01m04s/logs/apache-xml-security-c-2.0.1.log

Perhaps this was fixed in an update?
Comment 1 Nathan 2018-09-12 21:47:46 UTC 
Only port i see similar to this one listed is apache-xml-secuity-c and it was updated 5 weeks ago
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2018-09-13 13:08:25 UTC 
(In reply to Nathan from comment #1)
Sorry about that, meant security/apache-xml-security-c indeed

Can you please test to confirm with security/openssl111 and confirm build and run are OK? I can do the commit.
Comment 3 Nathan 2018-09-13 13:13:46 UTC 
(In reply to Bernard Spil from comment #2)
Yep sure will
Comment 4 Nathan 2018-09-13 16:32:04 UTC 
There is a build issue but will try work on it when I get on my pc at home
Comment 5 Nathan 2018-09-13 16:56:28 UTC 
Got to build but got to fix linker somehow as normal routes isn’t working for me yet
Comment 6 Nathan 2018-09-13 17:03:36 UTC 
Ok no linker issue after all. The only change it needs is ${OPENSSLLIB} to /use/local/lib. After that it built for me
Comment 7 Nathan 2018-09-13 17:06:05 UTC 
(In reply to Nathan from comment #6)
Need to strip a library file as well. Sorry on phone so makes it harder to fix and upload
Comment 8 Nathan 2018-09-14 01:13:01 UTC 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229022 May can be closed as it involves this one
Comment 9 Nathan 2018-09-14 01:20:25 UTC 
Created attachment 197082 [details]
Prepare for LLD on i386

Tested in 12-current(i386) built fine; I am unsure how this port works exactly but just executing the commands did not give segfaults
Comment 10 Nathan 2018-09-14 01:21:31 UTC 
BTW The changes on the patches are because I did make patch then make makepatch to generate patches correctly
Comment 11 Nathan 2018-09-14 01:25:06 UTC 
Created attachment 197083 [details]
Prepare for LLD on i386; Strip library file

Forgot to strip the library file, this corrects it
Comment 12 Tobias Kortkamp freebsd_committer freebsd_triage 2018-12-27 10:24:02 UTC 
security/apache-xml-security-c builds fine with OpenSSL 1.1.1 (ports r487344)
with the base version and security/openssl111.

Next time CC'ing the maintainer to give some feedback might help. ;-)
Comment 13 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-29 12:42:50 UTC 
Version 2.0.0 added support for OpenSSL 1.1 [1]. Girgen (maintainer) updated the port to 2.0.1 in ports r476595.

Tobias removed the BROKEN in ports r487344 (this PR was not referenced), so is the resolver of this issue.

[1] https://issues.apache.org/jira/browse/SANTUARIO-460