Bug 231512 - databases/sqlite3
Summary: databases/sqlite3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-20 12:17 UTC by Dean E. Weimer
Modified: 2018-09-20 13:46 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (pavelivolkov)


Attachments
Build Failure Output (10.43 KB, text/plain)
2018-09-20 12:55 UTC, Dean E. Weimer
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dean E. Weimer 2018-09-20 12:17:40 UTC
Build appears to be Broken after 3.25 update.

<command line>:55:28: warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
#define SQLITE_ENABLE_RTREE-DSQLITE_ENABLE_SESSION 1
                           ^
<command line>:55:9: warning: 'SQLITE_ENABLE_RTREE' macro redefined [-Wmacro-redefined]
#define SQLITE_ENABLE_RTREE-DSQLITE_ENABLE_SESSION 1
        ^
<command line>:39:9: note: previous definition is here
#define SQLITE_ENABLE_RTREE 1
        ^
sqlite3.c:308:5: error: token is not a valid binary operator in a preprocessor subexpression
#if SQLITE_ENABLE_RTREE
    ^~~~~~~~~~~~~~~~~~~
<command line>:55:52: note: expanded from here
#define SQLITE_ENABLE_RTREE-DSQLITE_ENABLE_SESSION 1
                           ~~~~~~~~~~~~~~~~~~~~~~~ ^
2 warnings and 1 error generated.
*** Error code 1

Stop.
make[2]: stopped in /var/ports/usr/ports/databases/sqlite3/work/sqlite-autoconf-3250000
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/databases/sqlite3
*** Error code 1
Comment 1 Pavel Volkov 2018-09-20 12:45:17 UTC
Hello Dean.
May I get your build log? And, may by your "make showconfig"? (And /etc/make.conf)?
Thank you.
Comment 2 Dean E. Weimer 2018-09-20 12:54:50 UTC
(In reply to Pavel Volkov from comment #1)
/etc/make.conf:
CFLAGS?= -O
CLFAGS+= -pipe
NO_WERROR=
WERROR=
.if ${CC:T} == "clang"
  CFLAGS+= -Qunused-arguments
.endif

# Port Configuration Options
WITH_CCACHE_BUILD= YES
OPTIONS_SET= LIBEDIT OPTIMIZED_CFLAGS GSSAPI_NONE
OPTIONS_UNSET= X11 X GUI TLS_SRP AVAHI GSSAPI_BASE XPM CUPS EXAMPLES
WRKDIRPREFIX= /var/ports
PACKAGES= /var/ports/packages
WITH_PKGNG= YES
DEFAULT_VERSIONS= pgsql=10 php=7.2 apache=2.4 perl5=5.28 python=2.7 bdb=6 mysql=10.3m ssl=libressl

Options:
# Options for sqlite3-3.25.0
_OPTIONS_READ=sqlite3-3.25.0
_FILE_COMPLETE_OPTIONS_LIST=ARMOR DBPAGE DBSTAT DIRECT_READ EXTENSION FTS3_TOKEN FTS4 FTS5 LIKENOTBLOB MEMMAN METADATA NULL_TRIM RBU SECURE_DELETE SORT_REF STMT STSHELL THREADS UNKNOWN_SQL UNLOCK_NOTIFY UPD_DEL_LIMIT URI URI_AUTHORITY TS0 TS1 TS2 TS3 STAT3 STAT4 JSON1 SESSION OFFSET SER1 SOUNDEX ICU UNICODE61 RTREE RTREE_INT GEOPOLY READLINES READLINEP EDITLINE
OPTIONS_FILE_UNSET+=ARMOR
OPTIONS_FILE_UNSET+=DBPAGE
OPTIONS_FILE_SET+=DBSTAT
OPTIONS_FILE_UNSET+=DIRECT_READ
OPTIONS_FILE_SET+=EXTENSION
OPTIONS_FILE_SET+=FTS3_TOKEN
OPTIONS_FILE_SET+=FTS4
OPTIONS_FILE_UNSET+=FTS5
OPTIONS_FILE_UNSET+=LIKENOTBLOB
OPTIONS_FILE_UNSET+=MEMMAN
OPTIONS_FILE_SET+=METADATA
OPTIONS_FILE_UNSET+=NULL_TRIM
OPTIONS_FILE_UNSET+=RBU
OPTIONS_FILE_SET+=SECURE_DELETE
OPTIONS_FILE_UNSET+=SORT_REF
OPTIONS_FILE_UNSET+=STMT
OPTIONS_FILE_SET+=STSHELL
OPTIONS_FILE_SET+=THREADS
OPTIONS_FILE_UNSET+=UNKNOWN_SQL
OPTIONS_FILE_SET+=UNLOCK_NOTIFY
OPTIONS_FILE_UNSET+=UPD_DEL_LIMIT
OPTIONS_FILE_SET+=URI
OPTIONS_FILE_UNSET+=URI_AUTHORITY
OPTIONS_FILE_UNSET+=TS0
OPTIONS_FILE_SET+=TS1
OPTIONS_FILE_UNSET+=TS2
OPTIONS_FILE_UNSET+=TS3
OPTIONS_FILE_UNSET+=STAT3
OPTIONS_FILE_UNSET+=STAT4
OPTIONS_FILE_UNSET+=JSON1
OPTIONS_FILE_SET+=SESSION
OPTIONS_FILE_UNSET+=OFFSET
OPTIONS_FILE_UNSET+=SER1
OPTIONS_FILE_UNSET+=SOUNDEX
OPTIONS_FILE_SET+=ICU
OPTIONS_FILE_UNSET+=UNICODE61
OPTIONS_FILE_SET+=RTREE
OPTIONS_FILE_UNSET+=RTREE_INT
OPTIONS_FILE_UNSET+=GEOPOLY
OPTIONS_FILE_UNSET+=READLINES
OPTIONS_FILE_UNSET+=READLINEP
OPTIONS_FILE_SET+=EDITLINE

Attaching full output of make, since the error appeared to be around the RTREE option I did try building without RTREE enabled in options, the error changed but build still failed.
Comment 3 Dean E. Weimer 2018-09-20 12:55:13 UTC
Created attachment 197275 [details]
Build Failure Output
Comment 4 Steve Wills freebsd_committer freebsd_triage 2018-09-20 13:34:11 UTC
Try disabling the SESSION option and see if it builds please?
Comment 5 Steve Wills freebsd_committer freebsd_triage 2018-09-20 13:42:48 UTC
I think I found the issue, it's in the configure script when session is enabled, missing a space in the define. I'll have a patch in a few.
Comment 6 Dean E. Weimer 2018-09-20 13:44:28 UTC
(In reply to Steve Wills from comment #4)
Yes it did build without session enabled.
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-09-20 13:46:53 UTC
I've committed the fix in r480170.