In 12-ALPHA6 the boot menu is displayed even if autoboot_delay is set to -1 in /boot/loader.conf. The menu is not usable, so it's not a security problem, just a cosmetic one.
I'll try and make some time to look at this in the next day or so.
Created attachment 197710 [details]
Lift autoboot_delay handling up a level
Apologies for the delay. How does the attached patch look for you?
Created attachment 197716 [details]
Lift autoboot_delay processing up a level
Revised patch- shouldn't affect this, but previous iteration broke the autoboot_delay="NO" case... invoking menu.autoboot with a nil delay will now do nothing, leaving the caller to come up with a reasonable default delay. This lines up with how I envision third-party usage (in, say, local.lua) to want to do things if they're invoking autoboot manually.
A commit references this bug:
Date: Fri Oct 5 17:07:11 UTC 2018
New revision: 339200
lualoader: Don't draw loader menu with autoboot_delay=-1
This was mostly a cosmetic issue. autoboot_delay=-1 is documented to bypass
the loader menu and immediately execute the boot command, but lualoader
would draw the menu and immediately execute the boot command. No interaction
was possible with the menu.
The fix lifts autoboot_delay processing out of menu.autoboot, which now
takes a delay and does nothing if no delay is specified. This lines up with
my expectations of menu.autoboot's usage from a third party, which may
want more control over the process than the default behavior.
Approved by: re (gjb)