Bug 231622 - net/mpd5: Remove BROKEN_SSL
Summary: net/mpd5: Remove BROKEN_SSL
Status: Closed DUPLICATE of bug 231599
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Eugene Grosbein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-23 02:49 UTC by Nathan
Modified: 2018-09-23 15:48 UTC (History)
1 user (show)

See Also:
eugen: maintainer-feedback+

Attachments
Unmark BROKEN_SSL (18.26 KB, patch)
2018-09-23 02:49 UTC, Nathan 		no flags Details | Diff
Unmark BROKEN_SSL (18.26 KB, patch)
2018-09-23 02:52 UTC, Nathan 		no flags Details | Diff
Unmark BROKEN_SSL (1.51 KB, patch)
2018-09-23 02:54 UTC, Nathan 		koobs: maintainer-approval-
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-09-23 02:49:01 UTC 
net/mpd5:
 
  - Unmark BROKEN_SSL, LDFLAGS fixes it
  - Re-arrange variables, none-OPTION relatated variables doesn't go after

Adding LDFLAGS= -L${LOCALBASE}/lib fixed "BROKEN" ssl
Comment 1 Nathan 2018-09-23 02:49:47 UTC 
Created attachment 197389 [details]
Unmark BROKEN_SSL

 net/mpd5:
 
  - Unmark BROKEN_SSL, LDFLAGS fixes it
  - Re-arrange variables, none-OPTION relatated variables doesn't go after
 
 PR:             231622
 Submitted by:   Nathan <ndowens@yahoo.com>
Comment 2 Nathan 2018-09-23 02:52:44 UTC 
Created attachment 197390 [details]
Unmark BROKEN_SSL

Fix typo in patch desc
Comment 3 Nathan 2018-09-23 02:54:41 UTC 
Created attachment 197391 [details]
Unmark BROKEN_SSL
Comment 4 Eugene Grosbein freebsd_committer freebsd_triage 2018-09-23 09:04:10 UTC 
mpd5 successfully compiles with openssl-devel or openssl111
but cannot be linked because it links with base system libfetch(3)
that currently links with /usr/lib/libssl.so.8 (openssl 1.0.2p-freebsd).

So, one should not attempt to build mpd5 with newer openssl version
until it's imported to base system so mpd5 won't link with two distinct
openssl versions.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2018-09-23 09:39:00 UTC 
Comment on attachment 197391 [details]
Unmark BROKEN_SSL

Also, since the USES=ssl provider (port) can be overridden by the user or the framework in various scenarios, one should always use the OPENSSL* variables from Uses/ssl.mk, who's values change based on the selection, and not use direct paths

@Eugen, in the absence of this or anything else (in the immediate term) as a fix/workaround, is this issue a closed/WONTFIX?
Comment 6 Eugene Grosbein freebsd_committer freebsd_triage 2018-09-23 09:52:31 UTC 
In fact, this is basically same as PR 231599.

This PR contains non-working patch, though: it does eliminate build errors but produces wrongly linked binary.

*** This bug has been marked as a duplicate of bug 231599 ***
Comment 7 Nathan 2018-09-23 15:43:35 UTC 
(In reply to Eugene Grosbein from comment #6)
How does it produce wrong linked binary? I tested overriding default version inside poudriere jail.
Comment 8 Nathan 2018-09-23 15:48:54 UTC 
(In reply to Nathan from comment #7)
Nevermind, just seen a reply that I didn't see before posting comment