Bug 231743 - devel/gearmand: fix build on powerpc64
Summary: devel/gearmand: fix build on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-26 15:54 UTC by Piotr Kubaj
Modified: 2018-11-07 03:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bdrewery)

Attachments
patch (2.22 KB, patch)
2018-09-26 15:54 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-09-26 15:54:57 UTC 
Created attachment 197522 [details]
patch

USES=compiler:c++11-lang in necessary, Boost detection is wrong (I removed it) and GCC needs additional include.

Tested on amd64 and powerpc64.

Hardware sponsored by IntegriCloud.
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2018-09-27 16:55:15 UTC 
Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-09-27 16:55:48 UTC 
A commit references this bug:

Author: bdrewery
Date: Thu Sep 27 16:55:06 UTC 2018
New revision: 480806
URL: https://svnweb.freebsd.org/changeset/ports/480806

Log:
  - Fix build on powerpc64

  PR:		231743
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/devel/gearmand/Makefile
  head/devel/gearmand/files/patch-configure
  head/devel/gearmand/files/patch-libtest_timer.hpp
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-11-07 03:31:07 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Nov  7 03:30:51 UTC 2018
New revision: 484381
URL: https://svnweb.freebsd.org/changeset/ports/484381

Log:
  devel/gearmand: drop duplicate USE_CXXSTD

  Building in C++11 or later (reverting r460065) doesn't work yet:

  libgearman/client.cc:580:71: error: comparison between pointer and integer ('gearman_connection_st *' and 'int')
      if (gearman_connection_create_args(client->universal, host, port) == false)
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~
  libgearman/client.cc:891:18: error: comparison between pointer and integer ('bool *' and 'int')
      if (is_known == false and is_running == false)
          ~~~~~~~~ ^  ~~~~~
  libgearman/client.cc:891:42: error: comparison between pointer and integer ('bool *' and 'int')
      if (is_known == false and is_running == false)
                                ~~~~~~~~~~ ^  ~~~~~

  PR:		231743
  Pointy hat to:	linimon

Changes:
  head/devel/gearmand/Makefile
Comment 4 Jan Beich freebsd_committer freebsd_triage 2018-11-07 03:43:49 UTC 
Ignore bogus "Pointy hat to" in comment 3. I guess, I deserve my own after getting it wrong, blaming an innocent peer.

USE_CXXSTD=gnu++98 was already defined in this port. Maybe USE* lines should be sorted, so USE_CXXSTD is easier to notice.