Bug 231752 - devel/libsoup: add USES=ssl
Summary: devel/libsoup: add USES=ssl
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2018-09-27 03:12 UTC by Charlie Li
Modified: 2018-10-01 01:44 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Li freebsd_committer freebsd_triage 2018-09-27 03:12:11 UTC
Patch: https://github.com/freebsd/freebsd-ports-gnome/pull/18

This port dynamically links with ssl, so add USES=ssl to account for any SONAME changes or whatnot. The omission leads to downstream build failures in certain situations; more on the gnome-development github PR.
Comment 1 Ting-Wei Lan 2018-09-27 13:56:54 UTC
Do you know where LibreSSL dependency pulled in? It sounds like an over linking issue to me because I cannot find any use of OpenSSL or LibreSSL in the source code of libsoup.
Comment 2 Charlie Li freebsd_committer freebsd_triage 2018-09-28 00:56:49 UTC
It's not LibreSSL specifically; it's any OpenSSL-like implementation, so the linkage happens no matter what. The issue exposes itself when the (primarily ports) SONAME changes. I counted six instances of -lcrypto in my build logs.
Comment 3 Ting-Wei Lan 2018-09-28 14:58:46 UTC
(In reply to Charlie Li from comment #2)
I know why libsoup links to libcrypto now: It is krb5 in base that pulls it in:
$ /usr/bin/krb5-config --libs
-L/usr/lib -lkrb5 -lhx509 -lcom_err -lcrypto -lasn1 -lwind -lheimbase -lroken -lcrypt -pthread

I configure libsoup to use MIT krb5 from ports so I didn't see it on my system. It seems to me that the same thing should be done on all ports depending on krb5. Adding USES=ssl on a port which doesn't use OpenSSL directly doesn't look like a nice solution to me.
Comment 4 Charlie Li freebsd_committer freebsd_triage 2018-10-01 01:44:54 UTC
Committed with the rest of the GNOME 3.28 update.