Bug 231851 - [patch] config: Error: device "atacard" is unknown, despite being described in sys/conf/NOTES
Summary: [patch] config: Error: device "atacard" is unknown, despite being described i...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-10-01 11:42 UTC by Yuri Pankov
Modified: 2019-05-21 19:04 UTC (History)
1 user (show)

See Also:

Attachments
change atapccard to atacard (578 bytes, patch)
2018-10-01 11:42 UTC, Yuri Pankov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Pankov 2018-10-01 11:42:45 UTC 
Created attachment 197672 [details]
change atapccard to atacard

sys/conf/NOTES:

#device         atacard         # CARDBUS support

...though using the following config fails with config: Error: device "atacard" is unknown:

include         GENERIC
ident           ATACARD

nodevice        ata

device          atacore
device          atacard
device          atapci
device          ataintel

Looks like sys/conf/files has the entry incorrect, listing it as "atapccard".  The attached patch fixes this.

P.S.: it could be done the other way round, fixing sys/conf/NOTES instead, but we seem to have "atacard" everywhere else, including the module name, so this looks to be more consistent.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2019-05-21 19:04:31 UTC 
Addressed by r344702
https://reviews.freebsd.org/rS344702