Bug 231868 - mail/thunderbird: update to 60.2.1
Summary: mail/thunderbird: update to 60.2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks: 231867
  Show dependency treegraph
 
Reported: 2018-10-01 20:57 UTC by Christoph Moench-Tegeder
Modified: 2018-10-01 22:03 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
thunderbird 60.2.1 (21.21 KB, patch)
2018-10-01 20:57 UTC, Christoph Moench-Tegeder
jbeich: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer freebsd_triage 2018-10-01 20:57:58 UTC
Created attachment 197696 [details]
thunderbird 60.2.1

looks like Mozilla just scrapped release 60.1.0 and goes straight to 60.2.1.

Attached patch updates our port (thunderbird and -i18n). Note: as the i686 xpi directory is rather incomplete (or was, when I checked) I swithed the xpi sources to x86_64.
Note 2: since the Gnome update both thunderbird and firefox both have errors in stage-qa:
  Error: /usr/local/lib/firefox/libxul.so is linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency
  Warning: you need USE_GNOME+=cairo

This should be adressed (shouldn't it?) but in the spirit of "one change at a time" I did not include it in this patch. Comments?

What's up with PR 228477?
Comment 1 Jan Beich freebsd_committer freebsd_triage 2018-10-01 21:23:32 UTC
Comment on attachment 197696 [details]
thunderbird 60.2.1

Looks OK. i686 appears to differ only in en-US locale due to timestamp.

--- en-US.xpi.i686
+++ en-US.xpi.x86_64
@@ -32,7 +32,7 @@
         "passwordmgr": "chrome/en-US/locale/en-US/passwordmgr/", 
         "pippki": "chrome/en-US/locale/en-US/pippki/"
       }, 
-      "version": "20180930230249"
+      "version": "20180930230952"
     }
   }, 
   "applications": {

> ... linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency

Probably overlinking from Gtk. Firefox uses bundled Cairo.

$ pkg-config gtk+-2.0 --libs
-L/usr/local/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lpthread -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lintl -lfontconfig -lfreetype

$ pkg-config gtk+-3.0 --libs
-L/usr/local/lib -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lpthread -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl
Comment 2 Charlie Li freebsd_committer freebsd_triage 2018-10-01 21:29:48 UTC
Looks like the i686 xpi directory filled up now. May want to change -i18n back.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-10-01 21:44:11 UTC
A commit references this bug:

Author: cmt
Date: Mon Oct  1 21:43:23 UTC 2018
New revision: 481073
URL: https://svnweb.freebsd.org/changeset/ports/481073

Log:
  mail/thunderbird: update to 60.2.1 (rc1)

  Release Notes: https://www.thunderbird.net/en-US/thunderbird/60.2.1/releasenotes/ (once ready)

  PR:		231868
  Approved by:	maintainer (jbeich, gecko)
  MFH:		2018Q4
  Security:	c96d416a-eae7-4d5d-bc84-40deca9329fb

Changes:
  head/mail/thunderbird/Makefile
  head/mail/thunderbird/distinfo
  head/mail/thunderbird-i18n/Makefile
  head/mail/thunderbird-i18n/distinfo
Comment 5 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2018-10-01 21:45:48 UTC
(In reply to Jan Beich from comment #3)

perhaps on some part of the CDN... I kept it on x86-64.

Are you going to MFH ports r481071? (that conflict was a little... surprising).
Comment 6 Charlie Li freebsd_committer freebsd_triage 2018-10-01 21:48:29 UTC
Looking at the timestamps on releases.mozilla, I doubt the missing files in i686 will ever get generated.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-10-01 21:58:23 UTC
A commit references this bug:

Author: cmt
Date: Mon Oct  1 21:57:38 UTC 2018
New revision: 481074
URL: https://svnweb.freebsd.org/changeset/ports/481074

Log:
  MFH: r481073

  mail/thunderbird: update to 60.2.1 (rc1)

  Release Notes: https://www.thunderbird.net/en-US/thunderbird/60.2.1/releasenotes/ (once ready)

  PR:		231868
  Approved by:	maintainer (jbeich, gecko)
  Security:	c96d416a-eae7-4d5d-bc84-40deca9329fb

  Approved by:	portmgr (blanket: web browsers and the like)

Changes:
_U  branches/2018Q4/
  branches/2018Q4/mail/thunderbird/Makefile
  branches/2018Q4/mail/thunderbird/distinfo
  branches/2018Q4/mail/thunderbird-i18n/Makefile
  branches/2018Q4/mail/thunderbird-i18n/distinfo
Comment 8 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2018-10-01 22:00:05 UTC
(In reply to Christoph Moench-Tegeder from comment #5)

Whatever. MFHed. (until the build starts, you can just sneek llvm70 in...). Gotta sleep sometimes :)
Comment 9 Jan Beich freebsd_committer freebsd_triage 2018-10-01 22:03:52 UTC
(In reply to Christoph Moench-Tegeder from comment #5)
> Are you going to MFH ports r481071? (that conflict was a little... surprising).

No. It's sort of an experiment. And I plan to keep 2018Q4 default to llvm60. As 10.4 reaches EOL in a month all supported FreeBSD versions would have Clang 6 in base, so there would be little benefit in using clang60 from llvm60 port.