Bug 232205 - japanese/groff: compile error
Summary: japanese/groff: compile error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-12 16:22 UTC by satosi.kimura
Modified: 2018-11-05 07:26 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (hrs)


Attachments
patch for japanese/groff (377 bytes, text/plain)
2018-10-12 16:22 UTC, satosi.kimura
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description satosi.kimura 2018-10-12 16:22:46 UTC
Created attachment 198068 [details]
patch for japanese/groff

On FreeBSD/amd64 11.2, japanese/groff fail to make as follows:

./charset.h:58:26: note: insert an explicit cast to silence this issue
0x00,0x97,0x00,0x98,0x00,0x99,0x00,0x9C,0x00,0x9E,0x00,
                         ^~~~
                         static_cast<char>( )
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.

(Although on FreeBSD/amd64 10.4, success to make.)

So, I modify it. This attachment is not patch of patch but
new file. Please put this file into directory "files".
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2018-10-23 07:52:02 UTC
The patch builds fine.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-05 06:54:58 UTC
Take.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-11-05 07:19:19 UTC
A commit references this bug:

Author: meta
Date: Mon Nov  5 07:18:47 UTC 2018
New revision: 484174
URL: https://svnweb.freebsd.org/changeset/ports/484174

Log:
  japanese/groff: unbreak the build

  While here,
  - Pet some portlint warnings (extra item in USES section)

  PR:		232205
  Submitted by:	satosi.kimura@nifty.ne.jp
  Sponsored by:	HAW International, Inc.

Changes:
  head/japanese/groff/Makefile
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-05 07:20:02 UTC
Committed, thanks for your contribution.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-11-05 07:26:26 UTC
A commit references this bug:

Author: meta
Date: Mon Nov  5 07:25:35 UTC 2018
New revision: 484175
URL: https://svnweb.freebsd.org/changeset/ports/484175

Log:
  My bad, forgot to add the patch to the previous commit

  PR:		232205
  Approved by:	mentors (implicit)

Changes:
  head/japanese/groff/files/patch-src-devices-grolbp-charset.h